Skip to content

Feature/70 view movie details #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marouaneaddou merged 2 commits into from
Sep 28, 2026
Merged

Feature/70 view movie details #152

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2706251
test(movie-details): add tests for retrieving movie data (#74)
marouaneaddou Sep 28, 2026
0375c7f
Merge branch 'main' into feature/70-View-Movie-Details
marouaneaddou Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 62 additions & 2 deletions ...test/java/com/filmexa/stream/modules/moviesExternal/serviceImpl/MovieServiceImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
/* By: maddou <maddou@student.42.fr> +#+ +:+ +#+ */
/* +#+#+#+#+#+ +#+ */
/* Created: 2026/09/26 12:52:27 by marouan #+# #+# */
/* Updated: 2026/09/28 22:13:35 by maddou ### ########.fr */
/* Updated: 2026/09/28 22:57:52 by maddou ### ########.fr */
/* */
/* ************************************************************************** */

Expand Down Expand Up @@ -38,14 +38,19 @@

import com.filmexa.stream.modules.moviesExternal.mapper.MovieMapper;
import com.filmexa.stream.modules.moviesExternal.client.MovieProvider;
import com.filmexa.stream.modules.moviesExternal.dto.tmdb.CastProviderData;
import com.filmexa.stream.modules.moviesExternal.dto.tmdb.GenreProviderData;
import com.filmexa.stream.modules.moviesExternal.dto.tmdb.MovieCreditsProviderData;
import com.filmexa.stream.modules.moviesExternal.serviceImpl.MovieServiceImpl;
import com.filmexa.stream.modules.moviesExternal.dto.tmdb.MovieDetailsProviderData;
import com.filmexa.stream.modules.moviesExternal.dto.tmdb.MovieDetailsProviderResponse;
import com.filmexa.stream.modules.moviesExternal.dto.tmdb.MovieProvederData;
import com.filmexa.stream.modules.moviesExternal.dto.tmdb.MoviesProviderData;
import com.filmexa.stream.modules.moviesExternal.dto.response.TrendingMoviesResponse;
import com.filmexa.stream.modules.moviesExternal.dto.tmdb.TmdbMoviesPageableResponse;
import com.filmexa.stream.modules.moviesExternal.dto.tmdb.trailer.TrailerData;
import com.filmexa.stream.modules.moviesExternal.dto.response.MovieDetailsResponse;
import com.filmexa.stream.modules.moviesExternal.dto.tmdb.request.TmdbMovieDiscoverRequest;
import com.filmexa.stream.modules.moviesExternal.enums.MovieSort;
import com.filmexa.stream.modules.moviesExternal.dto.request.MovieSearchQuery;
import com.filmexa.stream.modules.moviesExternal.dto.response.MoviePageResponse;
import com.filmexa.stream.modules.moviesExternal.dto.response.MovieResponse;
Expand Down Expand Up @@ -224,6 +229,61 @@ void shouldBuildHomeMovies() {
assertThat(homeData.get("Action").get(0).getTitle())
.isEqualTo("Spider-Man: Brand New Day");
}

@Test
void shouldReturnMovieById( ) {
MovieCreditsProviderData credits = new MovieCreditsProviderData(
List.of(
new CastProviderData(
6193,
"Leonardo DiCaprio",
"/wo2hJpn04vbtmh0B9utCFdsQhxM.jpg",
"Dom Cobb"
)
)
);
MovieProvederData inceptionMovie = new MovieProvederData(
8.373,
27205,
"Inception",
"/8ZTVqvKDQ8emSGUEMjsS4yHAwrp.jpg",
"/8ZTVqvKDQ8emSGUEMjsS4yHAwrp.jpg",
"tt1375666",
"en",
List.of( new GenreProviderData(
28,
"Action"
)
),
"test",
"2010-07-15",
false,
credits
);

when( movieProvider.getMovieById("en", 27205) )
.thenReturn( inceptionMovie );

when( movieProvider.getTraierMovie( 27205) )
.thenReturn(List.of(
new TrailerData(
1,
"Trailer",
"/watch?v=cdx31ak4KbQ"
)
));

MovieDetailsResponse response = movieService.getMovieById( "en", 27205 );

assertThat( response.getTitle() )
.isEqualTo("Inception");

assertThat( response.getActors().get(0).getName() )
.isEqualTo("Leonardo DiCaprio");

verify( movieProvider )
.getTraierMovie( 27205);
}

@Test
void shouldCallDiscoverMoviesWhenQueryIsNull() {
Expand Down
Loading