Skip to content

test(Search-movies): add tests for search movies (#69) #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marouaneaddou merged 1 commit into from
Sep 28, 2026
Merged

test(Search-movies): add tests for search movies (#69) #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/main/java/com/filmexa/stream/modules/moviesExternal/serviceImpl/MovieServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
/* ::: :::::::: */
/* MovieServiceImpl.java :+: :+: :+: */
/* +:+ +:+ +:+ */
/* By: marouan <marouan@student.42.fr> +#+ +:+ +#+ */
/* By: maddou <maddou@student.42.fr> +#+ +:+ +#+ */
/* +#+#+#+#+#+ +#+ */
/* Created: 2026/09/14 12:33:45 by maddou #+# #+# */
/* Updated: 2026/09/25 21:45:50 by marouan ### ########.fr */
/* Updated: 2026/09/28 21:53:54 by maddou ### ########.fr */
/* */
/* ************************************************************************** */

Expand Down Expand Up @@ -206,7 +206,6 @@ public MoviePageResponse searchMovie( MovieSearchQuery query, Pageable page ) {
);

}
System.out.println(query.getGenreId());
List<MovieDetailsProviderData> movies = movieProvider.searchMovieByQuery(
query.getLanguage(),
query.getQuery(),
Expand Down
102 changes: 101 additions & 1 deletion ...test/java/com/filmexa/stream/modules/moviesExternal/serviceImpl/MovieServiceImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
/* By: maddou <maddou@student.42.fr> +#+ +:+ +#+ */
/* +#+#+#+#+#+ +#+ */
/* Created: 2026/09/26 12:52:27 by marouan #+# #+# */
/* Updated: 2026/09/27 22:10:47 by maddou ### ########.fr */
/* Updated: 2026/09/28 22:13:35 by maddou ### ########.fr */
/* */
/* ************************************************************************** */

Expand All @@ -32,16 +32,21 @@
import static org.mockito.ArgumentMatchers.anyLong;
import static org.mockito.Mockito.verify;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.fail;
import static org.mockito.ArgumentMatchers.anyLong;
import static org.mockito.ArgumentMatchers.eq;

import com.filmexa.stream.modules.moviesExternal.mapper.MovieMapper;
import com.filmexa.stream.modules.moviesExternal.client.MovieProvider;
import com.filmexa.stream.modules.moviesExternal.serviceImpl.MovieServiceImpl;
import com.filmexa.stream.modules.moviesExternal.dto.tmdb.MovieDetailsProviderData;
import com.filmexa.stream.modules.moviesExternal.dto.tmdb.MovieDetailsProviderResponse;
import com.filmexa.stream.modules.moviesExternal.dto.tmdb.MoviesProviderData;
import com.filmexa.stream.modules.moviesExternal.dto.response.TrendingMoviesResponse;
import com.filmexa.stream.modules.moviesExternal.dto.tmdb.TmdbMoviesPageableResponse;
import com.filmexa.stream.modules.moviesExternal.dto.tmdb.request.TmdbMovieDiscoverRequest;
import com.filmexa.stream.modules.moviesExternal.enums.MovieSort;
import com.filmexa.stream.modules.moviesExternal.dto.request.MovieSearchQuery;
import com.filmexa.stream.modules.moviesExternal.dto.response.MoviePageResponse;
import com.filmexa.stream.modules.moviesExternal.dto.response.MovieResponse;
import com.filmexa.stream.common.exception.InvalidPaginationException;
Expand Down Expand Up @@ -219,4 +224,99 @@ void shouldBuildHomeMovies() {
assertThat(homeData.get("Action").get(0).getTitle())
.isEqualTo("Spider-Man: Brand New Day");
}

@Test
void shouldCallDiscoverMoviesWhenQueryIsNull() {
MovieSearchQuery query = new MovieSearchQuery(
"en",
null,
null,
2010,
null,
null
);
TmdbMovieDiscoverRequest providerParam = new TmdbMovieDiscoverRequest(
query.getLanguage(),
null,
query.getYear(),
query.getMinRating(),
"popularity.desc",
1
);
List<MoviesProviderData> movies = new ArrayList<>();
movies.add( new MoviesProviderData(
1423191L,
"Resident Evil",
"2026-09-16",
7.332,
"/i7UyjfPio0VFHB9rBUZSFyhOoM8.jpg",
false
));

TmdbMoviesPageableResponse responseProvider = new TmdbMoviesPageableResponse(
1,
500,
10000,
movies
);
Pageable page = PageRequest.of(0, 20);
when( movieProvider.discoverMovies( providerParam ))
.thenReturn(responseProvider);

MoviePageResponse response = movieService.searchMovie(
query, page
);

assertThat( response.getMovies() )
.hasSize( 1 );
assertThat( response.getMovies().get(0).getId() )
.isEqualTo(1423191L);

verify( movieProvider ).discoverMovies( providerParam );
}

@Test
void chouldCallSearchMovieByQueryWhenQuearyNotNull( ) {
MovieSearchQuery query = new MovieSearchQuery(
"en",
"Inception",
null,
2010,
null,
null
);
when( movieProvider.searchMovieByQuery(
"en",
"Inception",
2010,
1
))
.thenReturn(List.of(
new MovieDetailsProviderData(
27205L,
"Inception",
"test",
"2010-07-15",
"/xlaY2zyzMfkhk0HSC5VUwzoZPU1.jpg",
8.374,
List.of(27,878,12),
false
)
));

MoviePageResponse response = movieService.searchMovie(
query, PageRequest.of(1, 20)
);

assertThat( response.getMovies() )
.isNotEmpty();
assertThat( response.getMovies().get(0).getTitle())
.isEqualTo("Inception");
verify( movieProvider ).searchMovieByQuery(
"en",
"Inception",
2010,
1
);
}
}
Loading