Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
synapse-dev | 9d659b2 | Commit Preview URL Branch Preview URL |
Feb 23 2026, 08:02 PM |
rvagg
reviewed
Feb 19, 2026
rvagg
reviewed
Feb 19, 2026
rvagg
reviewed
Feb 19, 2026
| } | ||
| return false | ||
| }, | ||
| { concurrency: 5 } |
Collaborator
There was a problem hiding this comment.
Any reason not to increase this to 10 to make the most of concurrency potential? Most users will hopefully have 2 or 3 SPs they deal with so it won't matter much, but some will have more so we're doing a hunting expedition here for one that has the piece.
Member
Author
There was a problem hiding this comment.
browser normaly only do 5 to 6 paralell connections, after that they start to waterfall it, so 5 here seems good.
rvagg
reviewed
Feb 19, 2026
rvagg
approved these changes
Feb 19, 2026
Collaborator
rvagg
left a comment
rvagg
left a comment
There was a problem hiding this comment.
Approving with some suggestions inline. The ping comment is more than a suggestion though, wrong word and I'd like to see that changed before merging.
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.