Skip to content

refactor: remove receive() stubs#282

Merged
wjmelements merged 3 commits into
mainfrom
refactor/remove-receive-stubs
Jun 25, 2026
Merged

refactor: remove receive() stubs#282
wjmelements merged 3 commits into
mainfrom
refactor/remove-receive-stubs

Conversation

@wjmelements

Copy link
Copy Markdown
Contributor

Reviewer @ZenGround0 @rvagg
filecoin-services uses the fvm-solidity dep here.
I want to update fvm-solidity to remove the need for the receive fallback function, which isn't necessary when you use FVMPay.
Previous versions needed receive because the FVMPay mock previously used payable.transfer, but after this fix it now uses vm.deal to mock the SEND filecoin method.

Changes

  • update fvm-solidity dep
  • remove receive
  • add additional balance testing

@wjmelements wjmelements requested a review from rvagg June 24, 2026 20:07
@wjmelements wjmelements requested a review from ZenGround0 June 24, 2026 20:07
@FilOzzy FilOzzy added this to FOC Jun 24, 2026
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC Jun 24, 2026
@wjmelements wjmelements added the skip/changelog This change does not require CHANGELOG.md update label Jun 24, 2026

@rvagg rvagg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice work

@github-project-automation github-project-automation Bot moved this from 📌 Triage to ✔️ Approved by reviewer in FOC Jun 25, 2026
@wjmelements wjmelements merged commit 349940f into main Jun 25, 2026
3 checks passed
@wjmelements wjmelements deleted the refactor/remove-receive-stubs branch June 25, 2026 04:25
@github-project-automation github-project-automation Bot moved this to 🎉 Done in PDP Jun 25, 2026
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip/changelog This change does not require CHANGELOG.md update

Projects

Status: 🎉 Done
Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

3 participants