Open
Conversation
…step (#67) * Initial plan * Consolidate AWS CLI install and S3 upload into a single conditional step Co-authored-by: redpanda-f <181817029+redpanda-f@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: redpanda-f <181817029+redpanda-f@users.noreply.github.com>
redpanda-f
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Slack notifications for CI runs, including deep links to uploaded run artifacts, to improve visibility into nightly/CI health and debugging.
Changes:
- Introduces a new
Notify Slackworkflow that runs onworkflow_runcompletion of theCIworkflow and posts a structured Slack message. - Updates the
CIworkflow to run nightly on a cron schedule. - Adds AWS/S3 setup and a post-run upload step to sync
~/.foc-devnet/state/latestto S3 for later inspection.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/notify-slack.yml |
New workflow that queries CI job results and posts a Slack message with job status + S3 artifact links. |
.github/workflows/ci.yml |
Adds nightly schedule, AWS/S3 bootstrap, S3 upload of run state, and adjusts start invocation. |
Comment on lines
+372
to
+382
| # Upload state/latest directory to S3 for post-run inspection | ||
| # Path: s3://<CI_LOGS_BUCKET>/runs/<branch>/<run_id>/<run_attempt>/ | ||
| # Requires: AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, AWS_REGION secrets | ||
| # and CI_LOGS_BUCKET repository variable. | ||
| - name: "EXEC: {Install AWS CLI and upload state/latest to S3}, independent" | ||
| if: always() | ||
| env: | ||
| AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
| AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| AWS_DEFAULT_REGION: ${{ secrets.AWS_DEFAULT_REGION }} | ||
| CI_LOGS_BUCKET: ${{ secrets.CI_LOGS_BUCKET }} |
There was a problem hiding this comment.
The comments above this step say CI_LOGS_BUCKET is a "repository variable" and mention "AWS_REGION" secrets, but the workflow actually sources CI_LOGS_BUCKET and region from secrets.* (and uses AWS_DEFAULT_REGION). Please align the comments with the actual configuration to avoid confusion during setup/rotation.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It bases itself on #66, merge that before so diff is smaller