Skip to content

Comments

Replace duplicated "GOLOG_LOG_LEVEL=pdp=debug" with a named constant#63

Draft
Copilot wants to merge 2 commits intofeat/redpanda/allow-curio-debug-logsfrom
copilot/sub-pr-62
Draft

Replace duplicated "GOLOG_LOG_LEVEL=pdp=debug" with a named constant#63
Copilot wants to merge 2 commits intofeat/redpanda/allow-curio-debug-logsfrom
copilot/sub-pr-62

Conversation

Copy link
Contributor

Copilot AI commented Feb 24, 2026

The string "GOLOG_LOG_LEVEL=pdp=debug" was hardcoded in three places across db_setup.rs (×2) and daemon.rs, violating the project's no-magic-strings policy.

Changes

  • constants.rs — adds CURIO_PDP_DEBUG_LOG_LEVEL: &str = "GOLOG_LOG_LEVEL=pdp=debug"
  • db_setup.rs — imports and uses the constant in both call sites
  • daemon.rs — imports and uses the constant
// constants.rs
pub const CURIO_PDP_DEBUG_LOG_LEVEL: &str = "GOLOG_LOG_LEVEL=pdp=debug";

// db_setup.rs / daemon.rs (before)
docker_args.push("GOLOG_LOG_LEVEL=pdp=debug");

// after
docker_args.push(CURIO_PDP_DEBUG_LOG_LEVEL);

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

… string

Co-authored-by: redpanda-f <181817029+redpanda-f@users.noreply.github.com>
Copilot AI changed the title [WIP] Update logging and address Yugabyte CQL DDL feedback Replace duplicated "GOLOG_LOG_LEVEL=pdp=debug" with a named constant Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants