docs: clarify operator revocation, validator veto, and #274 leak formula#292
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #292 +/- ##
=======================================
Coverage ? 77.25%
=======================================
Files ? 5
Lines ? 554
Branches ? 107
=======================================
Hits ? 428
Misses ? 121
Partials ? 5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This was referenced Jun 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Documentation-only update to clarify several subtle/“gotcha” behaviors in FilecoinPayV1 around operator revocation scope, validator callbacks during termination, and the lockupUsage leak described in issue #274.
Changes:
- Clarifies that revoking an operator’s approval flag only affects rail creation, not authorization on existing rails.
- Documents validator-driven termination failure mode (and impact on the “settle without validation” escape hatch).
- Expands the #274 phantom
lockupUsageexplanation and provides an explicit leak formula.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| SPEC.md | Adds operator revocation scope notes, validator termination callback caveat, and elaborates the #274 phantom lockupUsage formula/impact. |
| README.md | Adds “revocation scope” warning, documents validator termination limitation, and refines the #274 leak formula explanation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rjan90
approved these changes
Jul 3, 2026
github-project-automation
Bot
moved this from 🔎 Awaiting review
to ✔️ Approved by reviewer
in FOC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this unstaged edit from an audit I did a couple of months ago.
I want to do some refactoring of the docs and figured these are worthwhile additions before I go ahead and propose moving things around.