test(jobs): add fake timers to data_set_lifecycle_check tests#637
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR stabilizes data_set_lifecycle_check scheduling tests by pinning the system clock with Vitest fake timers, preventing failures when the suite runs during the app’s maintenance window.
Changes:
- Enabled
vi.useFakeTimers()in the twodata_set_lifecycle_checkscheduling tests. - Fixed the perceived current time via
vi.setSystemTime(...)to a known-safe timestamp.
github-project-automation
Bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FOC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These test would fail if ran in wall clock maintenance window. By using fake timers this can be prevented.