Skip to content

test: cover data safety responses and CSV filling - #28

Open
GreedyC wants to merge 1 commit into
FidelisMM:mainfrom
GreedyC:codex/maintenance-data-safety-18
Open

GreedyC wants to merge 1 commit into
FidelisMM:mainfrom
GreedyC:codex/maintenance-data-safety-18

Conversation

@GreedyC

@GreedyC GreedyC commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

What

Closes #18.

Add offline unittest coverage for build_responses and fill_csv. The tests cover collected vs shared data, required vs optional controls, explicit and default purposes, deletion/encryption independence, account creation methods and deletion URLs. A synthetic UTF-8 CSV round trip checks updated values, preserved rows/columns and template, and missing response keys.

No production code, dependencies, workflows or store declarations change.

Tested against

  • Real store (which one, test app)

  • Only offline (unit tests, compile/import)

  • Python 3.12.13: full unittest suite, 36 tests passed.

  • Python 3.14.6 free-threaded: full unittest suite, 36 tests passed.

  • Documented Ruff E9/F and warnings-as-errors compile checks passed.

  • Server import/tool inventory smoke check: 60 tools.

  • A temporary mutation forcing shared data to use ONLY_COLLECTED broke both shared subcases. Restoring the unchanged production implementation restored the full green suite.

  • Actual Copilot CLI read-only review: two coverage findings corrected, final review reported no actionable findings.

Docker build was not run locally: the Docker daemon is unavailable. Linux/Windows execution and upstream CI are not claimed as locally verified. No store credentials, remote submissions or real app data were used.

AI assistance: Codex helped implement and verify the tests; Copilot CLI reviewed them. This is not a claim of human maintainer approval.

Checklist

  • Publishing tools say "External action" in the docstring (no publishing tools changed)
  • No credentials, real account ids or personal data
  • README "Hard-won lessons" updated if this fixes a store quirk (not applicable: test-only)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit tests for data_safety.build_responses

1 participant