Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #18.
Add offline unittest coverage for
build_responsesandfill_csv. The tests cover collected vs shared data, required vs optional controls, explicit and default purposes, deletion/encryption independence, account creation methods and deletion URLs. A synthetic UTF-8 CSV round trip checks updated values, preserved rows/columns and template, and missing response keys.No production code, dependencies, workflows or store declarations change.
Tested against
Real store (which one, test app)
Only offline (unit tests, compile/import)
Python 3.12.13: full unittest suite, 36 tests passed.
Python 3.14.6 free-threaded: full unittest suite, 36 tests passed.
Documented Ruff E9/F and warnings-as-errors compile checks passed.
Server import/tool inventory smoke check: 60 tools.
A temporary mutation forcing shared data to use ONLY_COLLECTED broke both shared subcases. Restoring the unchanged production implementation restored the full green suite.
Actual Copilot CLI read-only review: two coverage findings corrected, final review reported no actionable findings.
Docker build was not run locally: the Docker daemon is unavailable. Linux/Windows execution and upstream CI are not claimed as locally verified. No store credentials, remote submissions or real app data were used.
AI assistance: Codex helped implement and verify the tests; Copilot CLI reviewed them. This is not a claim of human maintainer approval.
Checklist