Repository navigation
test: cover set_privacy validation and record expansion - #14
Merged
Merged
Conversation
FidelisMM
approved these changes
Oct 2, 2026
FidelisMM
left a comment
Owner
There was a problem hiding this comment.
Thanks a lot @GreedyC, this is great! Exactly what #5 asked for: _run_iris is patched so nothing hits the network, the category × purpose × protection expansion is checked end to end, and the error messages are asserted verbatim, including the missing/empty/null purposes and the "nothing runs when a later usage is invalid" case. Ran it locally: 12/12 pass, ruff clean, CI green. Merging now.
This was referenced Oct 2, 2026
FidelisMM
added a commit
that referenced
this pull request
Oct 2, 2026
Contributor
Author
|
Thanks for the detailed review and for running the tests locally! Glad this covers #5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add offline unit tests for
apple_console.set_privacy:_run_iriscall when a later usage is invalid.The tests patch
_run_iris, inspect the serialized plan without executing JavaScript, and verify the returned result is forwarded. No production code changes.Fixes #5.
Tested against
12 unittest tests pass. CI's
ruff check src tests --select E9,Fpasses, as does warning-strict source compilation usingPath.read_text()to close files. CONTRIBUTING's broaderruff check srcreports existing findings in unchanged source files. Its literal compile command also emits unclosed-file ResourceWarnings; the context-safe equivalent passes.Checklist
AI assistance was used to write and verify these tests.