Skip to content

Split server.py into apple / play / eas tool modules #6

Open

Description

@FidelisMM

Why

server.py is about 2,100 lines with all 60 tools in one file. Splitting it by store makes each tool easier to find and review, and keeps a PR about Play from touching Apple code.

What to do

Move the tool functions into tools_apple.py, tools_play.py and tools_eas.py, registering on the same mcp instance. Keep the core diagnostics where they fit best.

  • Tool names, signatures and docstrings must stay identical (docstrings are what the agent reads).
  • Toolset filtering (SHIPSTORES_TOOLSETS, from Add configurable toolset filtering #11) must keep working.
  • Pure move: no behavior changes in the same PR, so review is just "same code, new place".

Done when

  • CI prints the same tool count (60)
  • SHIPSTORES_TOOLSETS=apple,eas gives the same 40 tools as before, play gives 23 and core gives 3
  • The Docker build in CI still passes
  • CI is green

This one is bigger than a good first issue. If you take it, comment first: #13 is touching server.py right now, and it's easier to land the move right after it.

Getting started

No store credentials or test app needed.

uv sync
uv run python -m unittest discover -s tests -v

Comment here if you'd like to take it, so nobody duplicates the work. Questions are welcome in this thread, and PRs usually get a review within a day.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedExtra attention is needed

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions