Repository navigation
Conversation
Runtime and time snapshots are user/message events but are not user input. Ignore only those known snapshot forms before classifying reply ownership, keeping real mixed-source turns blocked.
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
12 of 15 tasks
Ignore only the harness model-selection notice and recognize matching active-goal nudges as group continuations. Keep unknown, stale, mismatched, and user-originated goal events local.
7 of 8 tasks
Fei2411
reviewed
Nov 17, 2026
Fei2411
left a comment
Owner
There was a problem hiding this comment.
Verdict: COMMENT — recommend closing in favour of #1750; please port the tests.
- The fix only ignores DSH's
runtime-context/time-contextsnapshots. DS Bot's own snapshots (ds-bot-time-contextin time-context.js:42, andds-bot-memory-recall/ds-bot-memory-update/group memory in memory.js:919/932/962, allform: 'snapshot'on dev) still drop the origin, so #1735 stays partly broken. The new test{ kind: 'unknown-context', form: 'snapshot' }actually pins that behaviour. - #1750 returns early for any
form === 'snapshot'at the same spot, so it is a superset of this fix. - The test matrix is the best part of this PR: before/after × direct/group, 8 cases, all passing on dev a95e3af (2906/0). Porting it onto #1750 (dropping the
unknown-contextsnapshot case, or flipping it to expect delivery) would close the group-Session gap in #1750's tests. - #1765 says it depends on this PR. It should rebase on #1750 instead.
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #1767
An IM request correctly claims its reply chat, but DSH emits runtime/time snapshots and model-selection notices as
user/messagerecords. DS Bot treated those harness records as another user's input and silently cleared the IM origin. A later automatic goal check had the same effect, so long-running group progress stopped reaching Feishu even after ordinary replies and pictures worked.What changed / 改了什么
runtime-context/time-contextwithform: snapshot, andmodel-selectionwithform: notice, before consuming the pending group reset.bot/relay/goalnudge as a continuation only when its room ID and goal ID match the same currently active group goal. Like a late member post, it can preserve an existing origin but cannot invent a destination or revive a mixed turn.This does not upload images; the separate local-image pipeline is #1765. It also does not reconstruct origins after a restart or backfill previously omitted messages.
Changelog
Harness metadata and automatic checks of the same active goal no longer silently stop IM replies and later group progress.
Harness 系统上下文、模型切换通知及同一活动目标的自动检查不再导致 IM 回复和后续群聊进度被静默跳过。
How I checked it / 怎么验证的
node scripts/build-client.mjs --check,npm run lint(existing warnings),git diff --check.Checklist / 检查
Draft from the reporter's fork, subject to the repository's collaborator-only contribution policy.