Skip to content

[audit] mega-run packet; docs repair split to #29#24

Closed
Fearvox wants to merge 10 commits into
mainfrom
mega-24h-curator-2026-05-13
Closed

[audit] mega-run packet; docs repair split to #29#24
Fearvox wants to merge 10 commits into
mainfrom
mega-24h-curator-2026-05-13

Conversation

@Fearvox
Copy link
Copy Markdown
Owner

@Fearvox Fearvox commented May 13, 2026

Status

PR #24 is no longer the active docs-gate repair path.

The narrow repair was split into #29, which contains only:

  • .github/CONTRIBUTING.md
  • .github/workflows/docs.yml
  • .markdownlint.json

#29 has passing remote Docs checks and is the supersede path for red historical PRs #7 and #12.

What This PR Now Represents

This draft remains an owner-readable mega-run audit packet. It includes the docs-gate repair files plus .planning/mega-run/ evidence artifacts, so it should not be treated as the narrow merge path for #7/#12.

Changed Files

  • .github/CONTRIBUTING.md
  • .github/workflows/docs.yml
  • .markdownlint.json
  • .planning/mega-run/DECISIONS.md
  • .planning/mega-run/FINAL_REPORT.md
  • .planning/mega-run/GATE_RESULTS.md
  • .planning/mega-run/HEARTBEAT.txt
  • .planning/mega-run/ITER_LOG.md
  • .planning/mega-run/MAY_AGENT_REVIEW.md
  • .planning/mega-run/OWNER_BRIEF.md
  • .planning/mega-run/SCOREBOARD.md

Guardrail

Do not use this PR to claim #7/#12 became healthy. They were closed as superseded after #29 passed remote checks. This PR should remain draft until the owner decides whether the audit packet belongs in repo history.

Validation Already Observed

Rollback

Close this draft PR if the audit packet should remain outside repository history. The active repair path is #29.

Fearvox and others added 5 commits May 13, 2026 05:22
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
@Fearvox Fearvox added pr-mirror Long-lived mirror of an upstream PR for Linear/Slack tracking tracking Issue tracks a long-lived workflow labels May 13, 2026
Fearvox and others added 5 commits May 13, 2026 05:39
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
@Fearvox
Copy link
Copy Markdown
Owner Author

Fearvox commented May 13, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fe17bced35

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

if: steps.changed-markdown.outputs.count != '0'
with:
globs: ${{ steps.changed-markdown.outputs.files }}
config: .markdownlint.json
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include lint config in Docs path filters

Because this step now depends on .markdownlint.json, a PR that changes only that config file will not start this Docs workflow: the on.pull_request.paths/on.push.paths filters above only match Markdown/templates/workflow files, and GitHub evaluates paths against the changed files before running the workflow (docs). That lets an invalid or overly broad lint config merge without the markdown-lint job ever exercising it, potentially breaking the next Markdown-only PR; add .markdownlint.json to the workflow path filters.

Useful? React with 👍 / 👎.

@Fearvox
Copy link
Copy Markdown
Owner Author

Fearvox commented May 13, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fe17bced35

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

print(f"count={len(files)}")
PY

- uses: DavidAnson/markdownlint-cli2-action@v19
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid adding a third-party docs action

In the repo instructions I checked at /workspace/EverOS/AGENTS.md, .github/workflows/docs.yml is required to stay lightweight and dependency-free so docs hygiene remains easy to trust. This new job depends on an external DavidAnson/markdownlint-cli2-action release, so every Markdown-only PR now requires downloading/running a third-party action rather than the existing dependency-free Python/Ruby checks; replace this with an in-repo script or other dependency-free validation path.

Useful? React with 👍 / 👎.

if: steps.changed-markdown.outputs.count != '0'
with:
globs: ${{ steps.changed-markdown.outputs.files }}
config: .markdownlint.json
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Trigger docs checks when the lint config changes

Now that the workflow result depends on .markdownlint.json, a PR or push that changes only that config file will not run this workflow because the on.paths filters include Markdown/templates/workflow files but not the new config. In that scenario a broken or overly relaxed lint configuration can merge without the docs gate ever executing; add .markdownlint.json to both pull_request and push path filters.

Useful? React with 👍 / 👎.

@Fearvox
Copy link
Copy Markdown
Owner Author

Fearvox commented May 13, 2026

VERDICT: FLAG
VERDICT_SUMMARY:
#24 repairs the immediate docs-gate failures and the current remote markdown-lint and links checks are green.
One workflow trigger gap remains: .markdownlint.json changes do not currently trigger the docs workflow.
Next action: add .markdownlint.json to the pull_request and push path filters before treating this docs gate as fully maintainable.

EVIDENCE:

Finding:

  • Severity: Medium
  • File/path: .github/workflows/docs.yml
  • Evidence: the workflow path filters include **/*.md, .github/ISSUE_TEMPLATE/**, .github/PULL_REQUEST_TEMPLATE.md, and .github/workflows/docs.yml, but not .markdownlint.json; the PR adds .markdownlint.json and the markdown-lint job consumes it as config: .markdownlint.json.
  • Why it matters: changing lint policy without changing Markdown or docs.yml would not run the docs workflow, so lint configuration updates can bypass the gate they control.
  • Fix guidance: add .markdownlint.json to both pull_request.paths and push.paths, then confirm the docs workflow still runs and passes.

Clean evidence checked:

  • Current PR head: fe17bced35a1209eea815fd4d3fee81ba9ed56fd.
  • GitHub checks for [audit] mega-run packet; docs repair split to #29 #24: markdown-lint PASS and links PASS.
  • Changed-file collector limits markdownlint to changed Markdown files, which avoids failing on unrelated legacy Markdown debt.
  • .github/CONTRIBUTING.md placeholder link repair is covered by the passing links check.

Residual risk:

@Fearvox Fearvox changed the title [codex] repair fork docs gates [audit] mega-run packet; docs repair split to #29 May 14, 2026
@Fearvox
Copy link
Copy Markdown
Owner Author

Fearvox commented May 15, 2026

Closing as superseded by #29.

#29 merged the clean three-file docs-gate repair path and preserved the red-state truth for #7/#12. This PR now only adds the broader .planning/mega-run/ audit packet, so keeping it open would confuse the repair lane with run evidence. The audit trail remains represented in the local Curator pressure-test ledger; this PR is not being closed as unhealthy, just as no longer the active repo-history path.

@Fearvox Fearvox closed this May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-mirror Long-lived mirror of an upstream PR for Linear/Slack tracking tracking Issue tracks a long-lived workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant