[audit] mega-run packet; docs repair split to #29#24
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe17bced35
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if: steps.changed-markdown.outputs.count != '0' | ||
| with: | ||
| globs: ${{ steps.changed-markdown.outputs.files }} | ||
| config: .markdownlint.json |
There was a problem hiding this comment.
Include lint config in Docs path filters
Because this step now depends on .markdownlint.json, a PR that changes only that config file will not start this Docs workflow: the on.pull_request.paths/on.push.paths filters above only match Markdown/templates/workflow files, and GitHub evaluates paths against the changed files before running the workflow (docs). That lets an invalid or overly broad lint config merge without the markdown-lint job ever exercising it, potentially breaking the next Markdown-only PR; add .markdownlint.json to the workflow path filters.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe17bced35
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| print(f"count={len(files)}") | ||
| PY | ||
|
|
||
| - uses: DavidAnson/markdownlint-cli2-action@v19 |
There was a problem hiding this comment.
Avoid adding a third-party docs action
In the repo instructions I checked at /workspace/EverOS/AGENTS.md, .github/workflows/docs.yml is required to stay lightweight and dependency-free so docs hygiene remains easy to trust. This new job depends on an external DavidAnson/markdownlint-cli2-action release, so every Markdown-only PR now requires downloading/running a third-party action rather than the existing dependency-free Python/Ruby checks; replace this with an in-repo script or other dependency-free validation path.
Useful? React with 👍 / 👎.
| if: steps.changed-markdown.outputs.count != '0' | ||
| with: | ||
| globs: ${{ steps.changed-markdown.outputs.files }} | ||
| config: .markdownlint.json |
There was a problem hiding this comment.
Trigger docs checks when the lint config changes
Now that the workflow result depends on .markdownlint.json, a PR or push that changes only that config file will not run this workflow because the on.paths filters include Markdown/templates/workflow files but not the new config. In that scenario a broken or overly relaxed lint configuration can merge without the docs gate ever executing; add .markdownlint.json to both pull_request and push path filters.
Useful? React with 👍 / 👎.
|
VERDICT: FLAG EVIDENCE: Finding:
Clean evidence checked:
Residual risk:
|
|
Closing as superseded by #29. #29 merged the clean three-file docs-gate repair path and preserved the red-state truth for #7/#12. This PR now only adds the broader |
Status
PR #24 is no longer the active docs-gate repair path.
The narrow repair was split into #29, which contains only:
.github/CONTRIBUTING.md.github/workflows/docs.yml.markdownlint.json#29 has passing remote Docs checks and is the supersede path for red historical PRs #7 and #12.
What This PR Now Represents
This draft remains an owner-readable mega-run audit packet. It includes the docs-gate repair files plus
.planning/mega-run/evidence artifacts, so it should not be treated as the narrow merge path for #7/#12.Changed Files
.github/CONTRIBUTING.md.github/workflows/docs.yml.markdownlint.json.planning/mega-run/DECISIONS.md.planning/mega-run/FINAL_REPORT.md.planning/mega-run/GATE_RESULTS.md.planning/mega-run/HEARTBEAT.txt.planning/mega-run/ITER_LOG.md.planning/mega-run/MAY_AGENT_REVIEW.md.planning/mega-run/OWNER_BRIEF.md.planning/mega-run/SCOREBOARD.mdGuardrail
Do not use this PR to claim #7/#12 became healthy. They were closed as superseded after #29 passed remote checks. This PR should remain draft until the owner decides whether the audit packet belongs in repo history.
Validation Already Observed
Rollback
Close this draft PR if the audit packet should remain outside repository history. The active repair path is #29.