Repository navigation
Abyss stats: read-only Wallet from EVE, remove Loot (unsold) - #50
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44
Acceptance criteria
test_there_is_no_loot_stat_and_the_wallet_stat_is_there)test_shows_the_balance_from_eve...,test_reads_again_after_each_logged_run,test_reads_when_a_session_starts)test_signed_out_shows_a_dash_with_a_hint)test_a_read_error_shows_in_the_sub_line_and_logging_still_works)test_no_asset_polling_while_a_session_is_open)test_the_session_end_summary_has_no_loot_line)LootTableTestin test_core.py); backup/restore code untouchedWhat changed
Removed the loot poller, Loot stat, end-note line, Tracker loot methods, Baseline/Loot records, loot table creation and
value_change. Wallet stat is now read from ESI via the existing wallet reader. README loot section replaced. Newtest_wallet_page.pyreplacestest_loot_page.py.Double-check
The build machine has no tkinter/customtkinter, so the GUI tests (test_wallet_page, test_pocket, etc.) could not be run there; they were only compiled. Non-Tk tests pass (46 in core/export/loot/wallet). Please run the full suite with a display. The 'CONTEXT.md/ADR commit' mentioned in the spec is not part of this ticket's criteria and was not in the worktree.