Skip to content

Abyss stats: read-only Wallet from EVE, remove Loot (unsold) - #50

Merged
Fazorath merged 2 commits into
mainfrom
overnight/44-wallet-from-eve
Oct 26, 2026
Merged

Fazorath merged 2 commits into
mainfrom
overnight/44-wallet-from-eve

Conversation

@Fazorath

Copy link
Copy Markdown
Owner

Closes #44

Acceptance criteria

  • Stats are Session, ISK/hr, Time, Wallet; no Loot stat (test_there_is_no_loot_stat_and_the_wallet_stat_is_there)
  • Wallet shows ESI balance with 'from EVE at HH:MM', read on start, resume and after each logged run (test_shows_the_balance_from_eve..., test_reads_again_after_each_logged_run, test_reads_when_a_session_starts)
  • Signed out: '—' with sign-in hint (test_signed_out_shows_a_dash_with_a_hint)
  • Read error shows in sub-line, logging still works (test_a_read_error_shows_in_the_sub_line_and_logging_still_works)
  • No asset polling (poller removed; test_no_asset_polling_while_a_session_is_open)
  • No loot line in session-end summary (test_the_session_end_summary_has_no_loot_line)
  • New DB has no loot table; old DB with one still opens (LootTableTest in test_core.py); backup/restore code untouched
  • Loot page and baseline/valuation tests removed; asset and price reader tests kept
  • Full suite green: see note below

What changed

Removed the loot poller, Loot stat, end-note line, Tracker loot methods, Baseline/Loot records, loot table creation and value_change. Wallet stat is now read from ESI via the existing wallet reader. README loot section replaced. New test_wallet_page.py replaces test_loot_page.py.

Double-check

The build machine has no tkinter/customtkinter, so the GUI tests (test_wallet_page, test_pocket, etc.) could not be run there; they were only compiled. Non-Tk tests pass (46 in core/export/loot/wallet). Please run the full suite with a display. The 'CONTEXT.md/ADR commit' mentioned in the spec is not part of this ticket's criteria and was not in the worktree.

@Fazorath
Fazorath marked this pull request as ready for review October 26, 2026 15:35
@Fazorath
Fazorath merged commit 7af6c8d into main Oct 26, 2026
7 checks passed
@Fazorath
Fazorath deleted the overnight/44-wallet-from-eve branch October 26, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Abyss stats: read-only Wallet from EVE, remove Loot (unsold)

1 participant