Skip to content

Allow UDP to bind to the same ip/port #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TrentHouliston merged 2 commits into from
Aug 27, 2025
Merged

Allow UDP to bind to the same ip/port #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3494c6
Allow any on<UDP> to rebind to the same address not just broadcast or…
TrentHouliston Aug 5, 2025
81536ab
Update UDP.hpp
WongAaronSW Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 10 additions & 22 deletions src/dsl/word/UDP.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,32 +199,20 @@ namespace dsl {
}
}

// Broadcast and multicast reuse address and port
if (options.type == ConnectOptions::Type::BROADCAST
|| options.type == ConnectOptions::Type::MULTICAST) {

if (::setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, reinterpret_cast<char*>(&yes), sizeof(yes)) < 0) {
throw std::system_error(network_errno,
std::system_category(),
"Unable to reuse address on the socket");
}
if (::setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, reinterpret_cast<char*>(&yes), sizeof(yes)) < 0) {
throw std::system_error(network_errno,
std::system_category(),
"Unable to reuse address on the socket");
}

// If SO_REUSEPORT is available set it too
#ifdef SO_REUSEPORT
if (::setsockopt(fd, SOL_SOCKET, SO_REUSEPORT, reinterpret_cast<char*>(&yes), sizeof(yes)) < 0) {
throw std::system_error(network_errno,
std::system_category(),
"Unable to reuse port on the socket");
}
#endif

// We enable SO_BROADCAST since sometimes we need to send broadcast packets
if (::setsockopt(fd, SOL_SOCKET, SO_BROADCAST, reinterpret_cast<char*>(&yes), sizeof(yes)) < 0) {
throw std::system_error(network_errno,
std::system_category(),
"Unable to set broadcast on the socket");
}
if (::setsockopt(fd, SOL_SOCKET, SO_REUSEPORT, reinterpret_cast<char*>(&yes), sizeof(yes)) < 0) {
throw std::system_error(network_errno,
std::system_category(),
"Unable to reuse port on the socket");
}
#endif

// Bind to the address
if (::bind(fd, &bind_address.sock, bind_address.size()) != 0) {
Expand Down
19 changes: 18 additions & 1 deletion src/dsl/word/emit/UDP.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,24 @@ namespace dsl {
throw std::system_error(network_errno, std::system_category(), "Unable to open the UDP socket");
}

int yes = 1;
// Set reuse address and port so that emit can use the same port multiple times
if (::setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, reinterpret_cast<const char*>(&yes), sizeof(yes))
< 0) {
throw std::system_error(network_errno,
std::system_category(),
"Unable to set the reuse address option on the UDP socket");
}
#ifdef SO_REUSEPORT
// If SO_REUSEPORT is available set it too
if (::setsockopt(fd, SOL_SOCKET, SO_REUSEPORT, reinterpret_cast<const char*>(&yes), sizeof(yes))
< 0) {
throw std::system_error(network_errno,
std::system_category(),
"Unable to set the reuse port option on the UDP socket");
}
#endif

// If we are using multicast and we have a specific from_addr we need to tell the system to use the
// correct interface
if (multicast && !from_addr.empty()) {
Expand Down Expand Up @@ -145,7 +163,6 @@ namespace dsl {
}

// Assume that if the user is sending a broadcast they want to enable broadcasting
int yes = 1;
if (::setsockopt(fd, SOL_SOCKET, SO_BROADCAST, reinterpret_cast<const char*>(&yes), sizeof(yes))
< 0) {
throw std::system_error(network_errno,
Expand Down
Loading