Repository navigation
feat: add bilingual anti-defensive writing task skills - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and changes
FastWrite reads task catalog fields from
SKILL.md. The upstream Chinese and English skills have their own frontmatter. Read optional FastWrite metadata from an adjacentTASK.mdso the Agent selector can list both versions and the provider receives the original instructions.Users can select either language for draft, continue, and revise tasks. Both files and their MIT license are vendored from Adkid-Zephyr’s pinned upstream commit.
CI maintenance
Follow-up commits address release-check blockers without changing the vendored skills:
scripts/check-source-secrets.tsentry point already called bysecurity-check.shsince939814a. It checks tracked text files for explicit private-key headers and GitHub token formats, reports only file/line/rule, fails on Git or read errors, and avoids reading through symlinks. Keep the dependency audit and run five new scanner fixture tests. This is a limited source-pattern check, not a comprehensive secret or history scan.aria-pressedstate. The axe checks remain enabled at their original thresholds.Validation
Full Linux CI passed at
6797f5be2aa7436291e24b497202a84f261478d9:FastWrite release checks passed.Additional local checks: mail-delivery and skill-registry tests (8 passed); Nodemailer JSON transport exercised
createTransportandsendMailwithout sending email; both built skills and both licenses matched their source bytes. Selected-mode contrast also passed axe on the actual built UI in both themes and both writing modes (four states).Local Windows/Bun 1.4.2 testing had three unit failures that passed in isolation and one intermittent cross-tab refresh failure followed by two passing runs. The final Linux/Bun 1.4.3 run above passed without relaxing assertions or timeouts.