Skip to content

fix: connect API writing workflow and versioned PDF reviews - #2

Closed
QinXi-ai wants to merge 3 commits into
mainfrom
codex/functional-loop-fixes
Closed

QinXi-ai wants to merge 3 commits into
mainfrom
codex/functional-loop-fixes

Conversation

@QinXi-ai

@QinXi-ai QinXi-ai commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem and changes

Saving API settings previously left writing operations on the CLI provider because providerFor() returned undefined. Connect runtime/environment settings to an OpenAI-compatible Chat/Responses provider, retain CLI fallback, and report the actual transport and configuration state. Qwen3 Chat requests disable thinking to avoid exhausting interactive deadlines.

Share explicit operation schemas across API and CLI writing paths. Reject malformed outputs before persisting a review, and show a recoverable warning for older reports missing their recommendation instead of crashing.

Extract bounded text from the compiled PDF and pass it to Review with the compile snapshot's project version. Wait for the successful compile record before enabling PDF review, and reject stale text after flushing collaborative edits. Preserve the current main branch's immutable compile snapshots, diagnostics, and UI components. PDF review covers text, not visual layout or figures.

Install host LaTeX dependencies in CI/release checks and document the requirement. Remove the server's unsupported ignoreDeprecations: "6.0" setting so its configuration works with the repository's locked TypeScript 5.9.3.

Validation

Current-main integration (99110e9):

  • bun install --frozen-lockfile: passed.
  • bun run typecheck: passed.
  • git diff origin/main --check: passed; all merge conflicts resolved.
  • API/Review regression tests: 2 passed, 38 assertions.
  • bun run build: passed.
  • Windows full suite: 236 passed, 12 failed, with 9 reported errors. Failures are in Git sync/history tests (timeouts, path handling and CRLF expectations); this is not a full local PASS.
  • Initial Linux CI: 247 passed, 1 failed because the invitation-route test ran before web assets existed. Move the build before tests in release-check.sh; updated CI is pending.

Earlier live acceptance on 2026-09-16, before integrating the newer IDE changes:

  • Real remote Qwen3.8 27B and host LaTeX: 25/25 steps passed, from source/evidence import through drafting, completion, revision, PDF-text review, issue repair, targeted re-review, compilation, and source export.
  • Restart: six persisted API readbacks matched; the repaired issue remained resolved.
  • Playwright with Edge: six checks passed, with zero page errors. Malformed-response and legacy-report scenarios used explicit browser fixtures; model calls were verified separately in the live chain.

The live chain used synthetic acceptance material and a deliberately bounded issue. It demonstrates the software workflow, not scientific review quality. The remote model/browser acceptance has not been rerun on the main-integration commit. No production deployment is included. Local acceptance artifacts and temporary server/bridge scripts are excluded from this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants