Repository navigation
Yes shmonad - #5
Merged
Merged
Conversation
0x1NotMe
suggested changes
Dec 15, 2025
Contributor
There was a problem hiding this comment.
This PR reintroduces shMONAD as a runtime dependency for MEV settlement (and for payBidOnFail via committed funds). Any shMONAD pause/misconfig/revert will block settlement for otherwise-valid bids.
Requested changes focus on: (1) making the coupling explicit + documented, (2) fixing ABI/signature mismatches, and (3) adding basic guardrails/fallbacks so auctions don’t fail solely due to shMONAD/precompile edge cases.
Test/dev ergonomics note: current tests require MONAD_TESTNET_RPC_URL because BaseTest always forks; consider allowing a pure unit-test mode so contributors can run the mock-based tests without env setup.
0x1NotMe
self-requested a review
December 15, 2025 00:43
0x1NotMe
reviewed
Dec 15, 2025
0x1NotMe
self-requested a review
December 19, 2025 04:54
0x1NotMe
approved these changes
Dec 19, 2025
Route auction rewards via ShMonad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This auction only has two options
Uses committed shmonad funds for payBidOnFail
Uses the monad precompile to get ValId and sendExternalRewards on shmonad to pay ValId their MEV rewards