Repository navigation
Fix README to match actual contract implementation - #12
Merged
Merged
Conversation
The README documented functions, state variables, events, and mechanics that don't exist in the contract. Rewrote to accurately reflect the code. Key corrections: - Remove non-existent functions (activateValidator, updateValidatorProxy, clearValidatorProxy, and all view functions) - Remove non-existent state variables (POLICY_WRAPPER, proxyMap, validatorsBalanceMap, validatorsTotal) - Add missing targetBlockNumber parameter to flashExecutionBid signature - Fix event signatures (RelayFeeCollected uses uint64 validatorId, not address proxy; add missing RelayBidFailed event) - Fix auction type docs: top-of-block uses [bytes32(0)], not empty array - Remove fabricated gas-adjusted bidding and EOA-only restriction - Add repo structure, build/test/deploy instructions, and dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flashExecutionBidsignature (was missingtargetBlockNumberparam) and corrected auction type usage ([bytes32(0)]sentinel, not empty array)RelayBidFailedevent