Repository navigation
Conversation
- Use Script instead of Test as parent class for deploy script - Update error message to reflect new env var names - Reduce testnet deploy delay from 30s to 5s
jj1980a
reviewed
Jan 13, 2026
| shMonad = vm.envAddress("SHMONAD_ADDRESS_MAINNET"); | ||
| } | ||
|
|
||
| require(shMonad != address(0), "SHMONAD_ADDRESS is not set"); |
Contributor
There was a problem hiding this comment.
SHMONAD_ADDRESS_MAINNET can also be wrong, it's depending on IS_TESTNET value.
Comment on lines
-8
to
-9
| "deploy-testnet": "source .env && IS_TESTNET=true forge script script/deploy_fastlaneAuctionHandler.s.sol:DeployFastLaneAuctionHandlerScript --rpc-url $MONAD_TESTNET_RPC_URL --legacy --broadcast --delay 30 --private-key $DEPLOYER_PRIVATE_KEY", | ||
| "deploy-testnet-ledger": "source .env && IS_TESTNET=true forge script script/deploy_fastlaneAuctionHandler.s.sol:DeployFastLaneAuctionHandlerScript --rpc-url $MONAD_TESTNET_RPC_URL --legacy --broadcast --delay 30 --sender $DEPLOYER_LEDGER --ledger", |
Contributor
Author
There was a problem hiding this comment.
Okay cool can leave as 30
Contributor
Author
|
Closing, none of these changes are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scriptinstead ofTestas parent class for deploy script (semantically correct)