Repository navigation
docs(bench): re-capture AC#5 sample numbers and correct the headroom claim - #1850
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
bench/fastled-examplescarries the AC#5 gate (--max-warm-ms 50), but itsdocumented sample table was captured 2026-05-10 on Windows and its AC#5 text
claims "roughly 25× headroom over current ~1-2 ms warm timings". Neither
matches what the bench actually prints on this repo's Linux dev hosts: warm is
31-41 ms there, so the gate has 1.2-4.5× headroom, not 25×. A near-50 ms
warm number reads as noise under the old text; it is in fact a possible
resolver or host-load regression.
This is docs-only (README + one doc comment). No behaviour change, no test
change, no threshold change — the 50 ms AC#5 gate is untouched.
Measured (real output, not inferred)
NixOS, 16-core x86_64,
soldr cargo run --release -p fbuild-bench-fastled-examples --bin bench-fastled-examples -- --max-warm-ms 50,FASTLED_DIR=/home/niteris/dev/fastled, two consecutive runs at host load2.7-15.5, all rows
hit=yes, both runs exit 0:The 2026-05 Windows row is kept verbatim as the historical baseline; the new
Linux table is additive and dated, and notes that warm spread tracks host load.
Gates run
soldr cargo check --release -p fbuild-bench-fastled-examples --all-targets—rc 0 (
Finished release profile in 13.73s).No Rust logic changed, so the full
bash testsuite was not re-run.Refs #205.