Skip to content

docs(bench): re-capture AC#5 sample numbers and correct the headroom claim - #1850

Merged
zackees merged 1 commit into
mainfrom
agent/bench-ac5-sample-numbers
Nov 2, 2026
Merged

zackees merged 1 commit into
mainfrom
agent/bench-ac5-sample-numbers

Conversation

@zackees

@zackees zackees commented Nov 1, 2026

Copy link
Copy Markdown
Member

Why

bench/fastled-examples carries the AC#5 gate (--max-warm-ms 50), but its
documented sample table was captured 2026-05-10 on Windows and its AC#5 text
claims "roughly 25× headroom over current ~1-2 ms warm timings". Neither
matches what the bench actually prints on this repo's Linux dev hosts: warm is
31-41 ms there, so the gate has 1.2-4.5× headroom, not 25×. A near-50 ms
warm number reads as noise under the old text; it is in fact a possible
resolver or host-load regression.

This is docs-only (README + one doc comment). No behaviour change, no test
change, no threshold change — the 50 ms AC#5 gate is untouched.

Measured (real output, not inferred)

NixOS, 16-core x86_64, soldr cargo run --release -p fbuild-bench-fastled-examples --bin bench-fastled-examples -- --max-warm-ms 50,
FASTLED_DIR=/home/niteris/dev/fastled, two consecutive runs at host load
2.7-15.5, all rows hit=yes, both runs exit 0:

example cold (ms) warm (ms) speedup
Blink 80-94 32-39 2.1x
Pacifica 76-79 33-34 2.2x
Animartrix 91-91 36-41 2.2x
Audio 78-79 32-33 2.4x
BlurBenchmark 75-77 31-33 2.3x
Chromancer 80-82 33-34 2.4x

The 2026-05 Windows row is kept verbatim as the historical baseline; the new
Linux table is additive and dated, and notes that warm spread tracks host load.

Gates run

  • soldr cargo check --release -p fbuild-bench-fastled-examples --all-targets —
    rc 0 (Finished release profile in 13.73s).
  • AC#5 gate itself exercised twice by the two bench runs above (rc 0 both).

No Rust logic changed, so the full bash test suite was not re-run.

Refs #205.

@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@zackees
zackees added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit 552334d Nov 2, 2026
27 checks passed
@zackees
zackees deleted the agent/bench-ac5-sample-numbers branch November 2, 2026 00:36
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant