Skip to content

fix(daemon): stop calling a listener-less bind collision 'stale state' (refs #1700) - #1717

Merged
zackees merged 1 commit into
mainfrom
fix/1700-bind-collision-diagnostic
Oct 24, 2026
Merged

zackees merged 1 commit into
mainfrom
fix/1700-bind-collision-diagnostic

Conversation

@zackees

@zackees zackees commented Oct 24, 2026

Copy link
Copy Markdown
Member

Refs #1700 (diagnostic part only; endpoint/binding-scope policy is still open there).

The bind-retry warning claimed no listener present (stale state). As #1700 shows, EADDRINUSE with no listener also happens when an unrelated outgoing socket holds the port as its ephemeral port. The retry warning and the final failure now name both causes, and the final error points at the existing FBUILD_DAEMON_PORT override. Message-only change; cargo clippy -p fbuild-daemon --all-targets -D warnings clean.

…' (refs #1700)

Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 53 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between af838a4 and bd75524.

Files selected for processing: 1
  • crates/fbuild-daemon/src/main.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit aaa1e63 into main Oct 24, 2026
25 checks passed
@zackees
zackees deleted the fix/1700-bind-collision-diagnostic branch October 24, 2026 10:03
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant