Skip to content

fix(udev): print NixOS permanent form as services.udev.packages so it keeps the 70- name (#1654) - #1713

Merged
zackees merged 1 commit into
mainfrom
fix/1654-nixos-udev-packages
Oct 24, 2026
Merged

zackees merged 1 commit into
mainfrom
fix/1654-nixos-udev-packages

Conversation

@zackees

@zackees zackees commented Oct 24, 2026

Copy link
Copy Markdown
Member

Fixes #1654. NixOS writes services.udev.extraRules to 99-local.rules, after 73-seat-late.rules, so uaccess never applied. nixos_snippet and the rules header now point at services.udev.packages = [ (pkgs.writeTextDir "lib/udev/rules.d/70-fbuild.rules" '' ... '') ];. cargo test -p fbuild-cli udev: 27 passed; clippy clean.

… keeps the 70- name (#1654)

Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 39 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 87f2296 and f95a40c.

📒 Files selected for processing: 4
  • crates/fbuild-cli/src/cli/port_scan.rs
  • crates/fbuild-cli/src/cli/udev.rs
  • crates/fbuild-cli/src/cli/udev_install.rs
  • crates/fbuild-cli/src/cli/udev_install_tests.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit af838a4 into main Oct 24, 2026
25 checks passed
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

NixOS: printed services.udev.extraRules form lands in 99-local.rules, so uaccess never applies

1 participant