Repository navigation
fix(udev): tag tty/usb rules ID_MM_DEVICE_IGNORE so ModemManager skips boards (#1653) - #1712
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…s boards (#1653) Co-Authored-By: Claude <noreply@anthropic.com>
zackees
force-pushed
the
fix/1653-udev-mm-ignore
branch
from
October 24, 2026 01:45
aebbe78 to
0ac62c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1653. Generated tty and usb rules now carry
ENV{ID_MM_DEVICE_IGNORE}="1"(hidraw untouched; ModemManager doesn't probe it).70-fbuild.rulesalready sorts before80-mm-candidate.rules; new test asserts both.cargo test -p fbuild-cli udev: 28 passed; clippy clean. The optionalport doctorModemManager check is left out.