Repository navigation
chore(release): 2.5.39 - #1666
Merged
Merged
Conversation
Ships #1665: skip the ESP32-S3 QEMU ADC patch when adc_hw_calibration is not linked (FastLED#4813). Local-Gate: v1 tree=6a747824a198bec93c8287bf539b4894201a857d secs=1002 lanes=linux-minimal:run,dylint:run Ci-Attestation: {"at":1791525575,"gate":"general/all/ubuntu-ci-guards","host":"linux-x86_64","key":"86df93f4268327eeced27d95a49a94c82f017956b7e4588bfa598ab4a834de7a","lane":"linux-minimal","parents":["e0ba1c8d91a0a4a3d5eb76cd66d5a6b88cf9ab4e"],"secs":585,"stamp":"6447f85cfbd1b8e782eedd1a899f6eee","tree":"6a747824a198bec93c8287bf539b4894201a857d","v":1,"via":"run"} Ci-Attestation: {"at":1791525575,"gate":"rust/x86_64-unknown-linux-gnu/workspace-clippy","host":"linux-x86_64","key":"86df93f4268327eeced27d95a49a94c82f017956b7e4588bfa598ab4a834de7a","lane":"linux-minimal","parents":["e0ba1c8d91a0a4a3d5eb76cd66d5a6b88cf9ab4e"],"secs":585,"stamp":"814d3dfe456b17e162710c877569c730","tree":"6a747824a198bec93c8287bf539b4894201a857d","v":1,"via":"run"} Ci-Attestation: {"at":1791525575,"gate":"rust/x86_64-unknown-linux-gnu/workspace-test","host":"linux-x86_64","key":"86df93f4268327eeced27d95a49a94c82f017956b7e4588bfa598ab4a834de7a","lane":"linux-minimal","parents":["e0ba1c8d91a0a4a3d5eb76cd66d5a6b88cf9ab4e"],"secs":585,"stamp":"0fb262512e89255b38df2612ff329403","tree":"6a747824a198bec93c8287bf539b4894201a857d","v":1,"via":"run"} Ci-Attestation: {"at":1791525575,"gate":"rust/x86_64-unknown-linux-gnu/python-facade-test","host":"linux-x86_64","key":"86df93f4268327eeced27d95a49a94c82f017956b7e4588bfa598ab4a834de7a","lane":"linux-minimal","parents":["e0ba1c8d91a0a4a3d5eb76cd66d5a6b88cf9ab4e"],"secs":585,"stamp":"5d16bbd56a4d3cbd2011e3e86ec2e968","tree":"6a747824a198bec93c8287bf539b4894201a857d","v":1,"via":"run"} Ci-Attestation: {"at":1791525575,"gate":"general/all/dylint-policy","host":"linux-x86_64","key":"9707633704b74d7a7ebe85cdb68b0b5a632955445042593de3fb46aeaa1295eb","lane":"dylint","parents":["e0ba1c8d91a0a4a3d5eb76cd66d5a6b88cf9ab4e"],"secs":417,"stamp":"d0f51c22649fbf272d0aef101d526edc","tree":"6a747824a198bec93c8287bf539b4894201a857d","v":1,"via":"run"} Ci-Attestation: {"at":1791525575,"gate":"rust/x86_64-unknown-linux-gnu/dylint-library-check","host":"linux-x86_64","key":"9707633704b74d7a7ebe85cdb68b0b5a632955445042593de3fb46aeaa1295eb","lane":"dylint","parents":["e0ba1c8d91a0a4a3d5eb76cd66d5a6b88cf9ab4e"],"secs":417,"stamp":"1a3e5fb67bf37e9e8bc05785e53b663e","tree":"6a747824a198bec93c8287bf539b4894201a857d","v":1,"via":"run"} Ci-Attestation: {"at":1791525575,"gate":"rust/x86_64-unknown-linux-gnu/workspace-dylint","host":"linux-x86_64","key":"9707633704b74d7a7ebe85cdb68b0b5a632955445042593de3fb46aeaa1295eb","lane":"dylint","parents":["e0ba1c8d91a0a4a3d5eb76cd66d5a6b88cf9ab4e"],"secs":417,"stamp":"c44c6c7ec2f19c3ec22926607bfe8fc6","tree":"6a747824a198bec93c8287bf539b4894201a857d","v":1,"via":"run"}
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Cargo workspace and Python project versions change from 2.5.38 to 2.5.39. ChangesVersion Update
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to This release updates package versions; no actionable merge-blocking risk is evident in the changes. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 2.5.39. Ships #1665: skip the ESP32-S3 QEMU ADC calibration patch when
adc_hw_calibrationis not linked. That unblocks FastLED'sesp32s3_qemu_*jobs (FastLED/FastLED#4813) after FastLED/FastLED#4804 stopped linking the ADC constructor into ordinary sketches.Version bump only (
Cargo.toml,pyproject.toml,Cargo.lock). The local gate passed and is stamped.Summary by CodeRabbit