Skip to content

fix(symbols): restore weak vtable owners and exact linked-reference evidence #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zackees merged 3 commits into from
Oct 7, 2026
Merged

fix(symbols): restore weak vtable owners and exact linked-reference evidence #1663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5afd7f7
fix(symbols): preserve exact linked references and weak vtable owners
zackees Oct 7, 2026
3afddef
fix(symbols): validate dynamic images and normalize metadata discovery
zackees Oct 7, 2026
55895e8
test(symbols): use portable filesystem boundary for symlink fixture
zackees Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ targets = [
]

[workspace.package]
version = "2.5.37"
version = "2.5.38"
edition = "2021"
rust-version = "1.95.0"
license = "AGPL-3.0-only"
Expand Down
6 changes: 6 additions & 0 deletions crates/fbuild-build-engine/src/symbol_analyzer/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,9 @@ gate:
`SidecarOptions`, `write_sidecar_dot_files`, plus the internal
graph-section helpers.
- `tests.rs` — the unit tests for everything in the module.

`elf_references.rs` reads absolute method pointers from allocated Itanium
vtables, including AVR word addresses and ARM Thumb pointers.
`reference_analysis.rs` attributes disassembly by address and name, classifies
weak objects from their ELF sections, and records confirmed entry roots and
unexplained retention without guessing linker `KEEP` rules.
Loading
Loading