Repository navigation
fix: link ESP-IDF 4.4 radio archives from SDK ld - #1650
Merged
Merged
Conversation
Local-Gate: v1 tree=53c36b735851f2b72a84eacfcd91ae5b4e3bb563 secs=764 lanes=linux-minimal:run,dylint:run
Ci-Attestation: {"at":1791129158,"gate":"general/all/ubuntu-ci-guards","host":"linux-x86_64","key":"2ea1a9d6b92ced3df74ca7d7e209de580f0dbb6c5519809bcb63fc1f23cbaaba","lane":"linux-minimal","parents":["c38329f2e90f5878f939159d818ffcb3f5e5358f"],"secs":400,"stamp":"457b60e3db34caa853d6b863db6ae25d","tree":"53c36b735851f2b72a84eacfcd91ae5b4e3bb563","v":1,"via":"run"}
Ci-Attestation: {"at":1791129158,"gate":"rust/x86_64-unknown-linux-gnu/workspace-clippy","host":"linux-x86_64","key":"2ea1a9d6b92ced3df74ca7d7e209de580f0dbb6c5519809bcb63fc1f23cbaaba","lane":"linux-minimal","parents":["c38329f2e90f5878f939159d818ffcb3f5e5358f"],"secs":400,"stamp":"19f505a76cf6cc68295111d6c56e368f","tree":"53c36b735851f2b72a84eacfcd91ae5b4e3bb563","v":1,"via":"run"}
Ci-Attestation: {"at":1791129158,"gate":"rust/x86_64-unknown-linux-gnu/workspace-test","host":"linux-x86_64","key":"2ea1a9d6b92ced3df74ca7d7e209de580f0dbb6c5519809bcb63fc1f23cbaaba","lane":"linux-minimal","parents":["c38329f2e90f5878f939159d818ffcb3f5e5358f"],"secs":400,"stamp":"c5f34ff4f07e6c8e5fd1ba74bb43141b","tree":"53c36b735851f2b72a84eacfcd91ae5b4e3bb563","v":1,"via":"run"}
Ci-Attestation: {"at":1791129158,"gate":"rust/x86_64-unknown-linux-gnu/python-facade-test","host":"linux-x86_64","key":"2ea1a9d6b92ced3df74ca7d7e209de580f0dbb6c5519809bcb63fc1f23cbaaba","lane":"linux-minimal","parents":["c38329f2e90f5878f939159d818ffcb3f5e5358f"],"secs":400,"stamp":"50752d4521027425954e1e1f239d96ab","tree":"53c36b735851f2b72a84eacfcd91ae5b4e3bb563","v":1,"via":"run"}
Ci-Attestation: {"at":1791129158,"gate":"general/all/dylint-policy","host":"linux-x86_64","key":"2cc46a15c0aafa04ceb41b640ddd53391c795edc07ef7f606686a7656c4c8d58","lane":"dylint","parents":["c38329f2e90f5878f939159d818ffcb3f5e5358f"],"secs":364,"stamp":"c8a99b9577a65597f77df897eef083e1","tree":"53c36b735851f2b72a84eacfcd91ae5b4e3bb563","v":1,"via":"run"}
Ci-Attestation: {"at":1791129158,"gate":"rust/x86_64-unknown-linux-gnu/dylint-library-check","host":"linux-x86_64","key":"2cc46a15c0aafa04ceb41b640ddd53391c795edc07ef7f606686a7656c4c8d58","lane":"dylint","parents":["c38329f2e90f5878f939159d818ffcb3f5e5358f"],"secs":364,"stamp":"e357d67a244e3496cb3abe50e3ec5a94","tree":"53c36b735851f2b72a84eacfcd91ae5b4e3bb563","v":1,"via":"run"}
Ci-Attestation: {"at":1791129158,"gate":"rust/x86_64-unknown-linux-gnu/workspace-dylint","host":"linux-x86_64","key":"2cc46a15c0aafa04ceb41b640ddd53391c795edc07ef7f606686a7656c4c8d58","lane":"dylint","parents":["c38329f2e90f5878f939159d818ffcb3f5e5358f"],"secs":364,"stamp":"e4ef5e6509837af42d9f376f5446e8e4","tree":"53c36b735851f2b72a84eacfcd91ae5b4e3bb563","v":1,"via":"run"}
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughLegacy Arduino-ESP32 2.x library flag generation now searches the SDK’s ChangesLegacy ESP32 SDK library linking
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Legacy ESP32 builds now receive linker flags for radio archives stored in the SDK’s Security Architecture ReviewSecurity architecture risk: ⚪ Minimal · up to The fix adds radio archives from the existing SDK installation to the established linking process. The reviewed change introduces no demonstrated new privilege, external entrypoint, or security-control bypass. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arduino-ESP32 2.x keeps radio archives (
libphy.a,librtc.a, and related libraries) intools/sdk/esp32/ld, outside the common SDKlibdirectory. The fallback SDK linker list now includes that archive directory. Bump fbuild to 2.5.36 for the FastLED pin.The focused regression test failed before the fix and passes after it.
fbuild-librarytests, formatting, Clippy, and the source-bound local gate pass. With the patched binary,esp32dev_idf44OTA and the full 97-example catalog pass; the published 2.5.35 build reproduces OTA's missing radio symbols.Tracks FastLED/FastLED#4686.
Summary by CodeRabbit
lddirectory are included in builds.