Skip to content

Prove ordinary PR Dylint with source-bound shared replay - #1648

Merged
zackees merged 1 commit into
mainfrom
feat/shared-dylint-proof
Oct 4, 2026
Merged

zackees merged 1 commit into
mainfrom
feat/shared-dylint-proof

Conversation

@zackees

@zackees zackees commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

Prove the entire ordinary-PR Dylint workflow with the shared ci.yml verifier, using a separate source-bound receipt from the Ubuntu lane. Both lanes must pass before stamping; each validates its original Bosn report against exact source/tree, event, job coverage, executed checks and engine cleanup.

Name the existing Dylint actions and aggregator command without changing their commands or conditions. Declare all three Dylint jobs with an unfiltered pull_request selection. The library cache save retains its exact-hit guard and uses the shared checker’s narrowly matched cache-save skip handling. Existing private Dylint checks remain additional evidence. Native Linux attestations are separate from board and other native/full coverage, which retain their existing remote behavior.

Validation: RED missing Dylint selection, then 33 focused tests, generated workflow drift and Python complexity checks passed. Read-only clud-review is clean. Full committed-source gate passed in 1214s: Ubuntu 720s and Dylint 494s, each with all three jobs successful and engine cleanup removed. The shared checker accepted both original reports and stamped seven tree-bound attestations on tree 48c9a1206fcc9328b12ed6ce0a066d5c334386d4.

Coordinated with zackees/ci.yml#298 and #299 (merged). Related to #1635 and #1643. No new workflows, extra full/native labels or cache-policy changes.

Summary by CodeRabbit

  • Chores
    • Local validation now supports separate Linux and Dylint checks, with both runs enabled by default or either lane available individually.
    • Dylint validation now covers native workflow jobs and checks that replay reports are valid before verification.
    • Pull request checks use an updated pinned validation version. Workflow names and guidance have also been clarified.

Local-Gate: v1 tree=48c9a1206fcc9328b12ed6ce0a066d5c334386d4 secs=1214 lanes=linux-minimal:run,dylint:run
Ci-Attestation: {"at":1791121888,"gate":"general/all/ubuntu-ci-guards","host":"linux-x86_64","key":"97227f62000204e1027fde1b055d5e4f3e7272e38fc158b979cdfa34b57f059c","lane":"linux-minimal","parents":["ed1d82303a53f134a4d1bbbbb02dcc11b34070de"],"secs":720,"stamp":"bf5ea3fc4af495cc66667c2c7054e3af","tree":"48c9a1206fcc9328b12ed6ce0a066d5c334386d4","v":1,"via":"run"}
Ci-Attestation: {"at":1791121888,"gate":"rust/x86_64-unknown-linux-gnu/workspace-clippy","host":"linux-x86_64","key":"97227f62000204e1027fde1b055d5e4f3e7272e38fc158b979cdfa34b57f059c","lane":"linux-minimal","parents":["ed1d82303a53f134a4d1bbbbb02dcc11b34070de"],"secs":720,"stamp":"f404d2497ea9e5b16e2fb2e9559888af","tree":"48c9a1206fcc9328b12ed6ce0a066d5c334386d4","v":1,"via":"run"}
Ci-Attestation: {"at":1791121888,"gate":"rust/x86_64-unknown-linux-gnu/workspace-test","host":"linux-x86_64","key":"97227f62000204e1027fde1b055d5e4f3e7272e38fc158b979cdfa34b57f059c","lane":"linux-minimal","parents":["ed1d82303a53f134a4d1bbbbb02dcc11b34070de"],"secs":720,"stamp":"26f7dd2df58eaefde2ee9671d108ec8e","tree":"48c9a1206fcc9328b12ed6ce0a066d5c334386d4","v":1,"via":"run"}
Ci-Attestation: {"at":1791121888,"gate":"rust/x86_64-unknown-linux-gnu/python-facade-test","host":"linux-x86_64","key":"97227f62000204e1027fde1b055d5e4f3e7272e38fc158b979cdfa34b57f059c","lane":"linux-minimal","parents":["ed1d82303a53f134a4d1bbbbb02dcc11b34070de"],"secs":720,"stamp":"694bb464d06eb07aa9d7b53f92d57d74","tree":"48c9a1206fcc9328b12ed6ce0a066d5c334386d4","v":1,"via":"run"}
Ci-Attestation: {"at":1791121888,"gate":"general/all/dylint-policy","host":"linux-x86_64","key":"5170970aefa485d70fc0b96579f90322439962022ffa689e494af27ecbcb5f17","lane":"dylint","parents":["ed1d82303a53f134a4d1bbbbb02dcc11b34070de"],"secs":494,"stamp":"b1774f5ef8719caac00c2ebfa17d6d6a","tree":"48c9a1206fcc9328b12ed6ce0a066d5c334386d4","v":1,"via":"run"}
Ci-Attestation: {"at":1791121888,"gate":"rust/x86_64-unknown-linux-gnu/dylint-library-check","host":"linux-x86_64","key":"5170970aefa485d70fc0b96579f90322439962022ffa689e494af27ecbcb5f17","lane":"dylint","parents":["ed1d82303a53f134a4d1bbbbb02dcc11b34070de"],"secs":494,"stamp":"03307ebad10bde2b9ba802fc7523abd5","tree":"48c9a1206fcc9328b12ed6ce0a066d5c334386d4","v":1,"via":"run"}
Ci-Attestation: {"at":1791121888,"gate":"rust/x86_64-unknown-linux-gnu/workspace-dylint","host":"linux-x86_64","key":"5170970aefa485d70fc0b96579f90322439962022ffa689e494af27ecbcb5f17","lane":"dylint","parents":["ed1d82303a53f134a4d1bbbbb02dcc11b34070de"],"secs":494,"stamp":"2e2662cdf3c086c9fc8e1c590a2d4a7b","tree":"48c9a1206fcc9328b12ed6ce0a066d5c334386d4","v":1,"via":"run"}
@coderabbitai

coderabbitai Bot commented Oct 4, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: FastLED/fbuild/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7ac0e3c7-2a11-4446-a6be-3912724aa286
📥 Commits

Reviewing files that changed from the base of the PR and between ed1d823 and 5ff5895.

📒 Files selected for processing (9)
  • .github/workflows/ci-minimal.yml
  • .github/workflows/dylint.yml
  • ci-attestations.yml
  • ci/README.md
  • ci/local_dylint_gate.py
  • ci/local_gate.py
  • ci/render_workflows.py
  • ci/test_shared_replay.py
  • local-gate.toml
 _____________________________________________________________________________________________________
< Trained in all forms of code review, from the ancient art of waterfall to the modern ways of agile. >
 -----------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit 430a64f into main Oct 4, 2026
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant