Skip to content

Bind reusable Ubuntu gate to shared executed-step proof - #1647

Merged
zackees merged 1 commit into
mainfrom
feat/shared-replay-proof
Oct 4, 2026
Merged

zackees merged 1 commit into
mainfrom
feat/shared-replay-proof

Conversation

@zackees

@zackees zackees commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

Bind the existing reusable Ubuntu local gate to ci.yml’s shared executed-step verifier. The declaration covers both Ubuntu jobs and their verifier prerequisite; their original Bosn terminal receipt must prove the exact clean commit/tree, selection, successful checks, and engine cleanup before the outer gate stamps HEAD.

Name every action step, generate the verifier’s explicit PR/dispatch decision through ci/render_workflows.py, and pin the shared checker. PRs still require an attestation; dispatch can validate a source before stamping. The wrapper uses released Bosn 0.1.13 with optional session state. Ordinary-PR Dylint still executes and validates its policy/library/workspace checks before stamping. Board selection, native tiers, full/release coverage and cache policy are preserved.

Validation: RED missing replay declaration and six unnamed actions; GREEN 32 focused tests, generator drift, Python complexity and clean read-only clud-review. The generated shell decision refuses a failed PR attestation while permitting dispatch. Full committed-source gate passed in 738 seconds: Ubuntu replay a39e39e8 (408 seconds) and ordinary-PR Dylint replay 5c11d916, all six job verdicts successful and both engines removed. The shared verifier accepted the original Ubuntu receipt. The stamped identical tree reused its attestation without another engine run; pre-push validation passed. This is one correctness run, not a controlled cold/warm performance comparison.

Coordinated with zackees/ci.yml#297 (merged). Related to #1635 and #1643; this does not claim complete cold/warm measurement or shared Dylint proof adoption.

Summary by CodeRabbit

  • Chores

    • Updated continuous integration checks to provide clearer step labels and consistent verification behavior across pull-request and manual workflow runs.
    • Added replay configuration for Ubuntu checks and local verification, with reports passed through for validation.
  • Tests

    • Added coverage to validate the shared workflow replay configuration and confirm verification behavior across supported event types.

Local-Gate: v1 tree=748674ed86f70a252d4e9dcb47a17fb80ed91768 secs=738 lanes=linux-minimal:run
Ci-Attestation: {"at":1791118848,"gate":"general/all/ubuntu-ci-guards","host":"linux-x86_64","key":"fa75d804a018bc7cd3f84d8a8dfb6623409c6624aabf1f96f81cac97c3ca38ab","lane":"linux-minimal","parents":["35f1b2292cf41153adf900e32745f42cb5e3cd64"],"secs":738,"stamp":"d8052296726db355fe22d421642ccccf","tree":"748674ed86f70a252d4e9dcb47a17fb80ed91768","v":1,"via":"run"}
Ci-Attestation: {"at":1791118848,"gate":"rust/x86_64-unknown-linux-gnu/workspace-clippy","host":"linux-x86_64","key":"fa75d804a018bc7cd3f84d8a8dfb6623409c6624aabf1f96f81cac97c3ca38ab","lane":"linux-minimal","parents":["35f1b2292cf41153adf900e32745f42cb5e3cd64"],"secs":738,"stamp":"cc6d9c189299c8ad591fae8752969e4f","tree":"748674ed86f70a252d4e9dcb47a17fb80ed91768","v":1,"via":"run"}
Ci-Attestation: {"at":1791118848,"gate":"rust/x86_64-unknown-linux-gnu/workspace-test","host":"linux-x86_64","key":"fa75d804a018bc7cd3f84d8a8dfb6623409c6624aabf1f96f81cac97c3ca38ab","lane":"linux-minimal","parents":["35f1b2292cf41153adf900e32745f42cb5e3cd64"],"secs":738,"stamp":"fc1453e5e4c84b0d6366c4a71eee77de","tree":"748674ed86f70a252d4e9dcb47a17fb80ed91768","v":1,"via":"run"}
Ci-Attestation: {"at":1791118848,"gate":"rust/x86_64-unknown-linux-gnu/python-facade-test","host":"linux-x86_64","key":"fa75d804a018bc7cd3f84d8a8dfb6623409c6624aabf1f96f81cac97c3ca38ab","lane":"linux-minimal","parents":["35f1b2292cf41153adf900e32745f42cb5e3cd64"],"secs":738,"stamp":"2f486fbd4d52b839f9f2593f5a02c5f7","tree":"748674ed86f70a252d4e9dcb47a17fb80ed91768","v":1,"via":"run"}
@coderabbitai

coderabbitai Bot commented Oct 4, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: FastLED/fbuild/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4d3699da-ca96-48bd-aefb-b337467c13bc
📥 Commits

Reviewing files that changed from the base of the PR and between 35f1b22 and e555e59.

📒 Files selected for processing (9)
  • .github/workflows/check-ubuntu.yml
  • .github/workflows/ci-minimal.yml
  • ci/README.md
  • ci/local_dylint_gate.py
  • ci/local_gate.py
  • ci/render_workflows.py
  • ci/test_fractional_workflows.py
  • ci/test_shared_replay.py
  • local-gate.toml
 _____________________________________________________________________________
< I took both the red pill and the blue pill. Now I'm stuck in a code review. >
 -----------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit ed1d823 into main Oct 4, 2026
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant