ci: remove duplicated cache-key-suffix keys from check-ubuntu.yml - #1611
Merged
Merged
Conversation
#1587 added a second cache-key-suffix to two setup-soldr `with:` blocks. Duplicate keys make the workflow invalid, so since 2026-10-01 check-ubuntu and ci-minimal (which calls it) fail on every push with 'workflow file issue' and run zero jobs: no clippy or unit tests ran on main. Co-Authored-By: Claude <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 6 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: FastLED/fbuild/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since 2026-10-01, every push to main shows
check-ubuntu.ymlandci-minimal.yml(which calls it) failing with "This run likely failed because of a workflow file issue", and they start zero jobs. No clippy, unit tests or python-facade tests have run on main or on PRs since then (#1605/#1606/#1608/#1609/#1610 merged without them).Cause
#1587 added a second
cache-key-suffixto two setup-soldrwith:blocks that already had one, with the same values (check-ubuntu,python-facades). actionlint:Fix
Drop the duplicates and fold the second comment's rationale into the surviving key. No behaviour change, since the values were identical.
Evidence
actionlintreports no syntax errors across all workflows after the change. This PR's own checks should now include the check-ubuntu jobs.