chore: update embedded zccache dependency - #1535
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 38 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: FastLED/fbuild/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advances fbuild's embedded zccache dependency from
3f9d4e6to upstream9bc8b4d, consistently across all platform/build crates. The lockfile now resolves zccache's current dependency set, includingkernal-api 0.1.23.This brings the embedded service onto the latest upstream implementation after the previous pin. The published ESP32-S3 cold benchmark will be rerun after merge to measure the effect.
Validation:
soldr cargo check -p fbuild-build -p fbuild-build-engine -p fbuild-build-esp -p fbuild-build-mcu -p fbuild-build-arm --all-targetssoldr cargo test -p fbuild-build --test zccache_embedded_smoke(2 passed, including cold miss followed by warm hit)git diff --checkThe benchmark workflow's path filter does not include these dependency manifests, so it must be dispatched on
mainafter this PR merges.