Skip to content

chore: update embedded zccache dependency - #1535

Merged
zackees merged 1 commit into
mainfrom
perf/zccache-embedded-update
Sep 28, 2026
Merged

zackees merged 1 commit into
mainfrom
perf/zccache-embedded-update

Conversation

@zackees

@zackees zackees commented Sep 28, 2026

Copy link
Copy Markdown
Member

Advances fbuild's embedded zccache dependency from 3f9d4e6 to upstream 9bc8b4d, consistently across all platform/build crates. The lockfile now resolves zccache's current dependency set, including kernal-api 0.1.23.

This brings the embedded service onto the latest upstream implementation after the previous pin. The published ESP32-S3 cold benchmark will be rerun after merge to measure the effect.

Validation:

  • soldr cargo check -p fbuild-build -p fbuild-build-engine -p fbuild-build-esp -p fbuild-build-mcu -p fbuild-build-arm --all-targets
  • soldr cargo test -p fbuild-build --test zccache_embedded_smoke (2 passed, including cold miss followed by warm hit)
  • git diff --check

The benchmark workflow's path filter does not include these dependency manifests, so it must be dispatched on main after this PR merges.

@coderabbitai

coderabbitai Bot commented Sep 28, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 38 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: FastLED/fbuild/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 09849a92-dcfd-4241-8f45-2bf801edd97f

📥 Commits

Reviewing files that changed from the base of the PR and between 3d0682e and ea93d33.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (5)
  • crates/fbuild-build-arm/Cargo.toml
  • crates/fbuild-build-engine/Cargo.toml
  • crates/fbuild-build-esp/Cargo.toml
  • crates/fbuild-build-mcu/Cargo.toml
  • crates/fbuild-build/Cargo.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit d243d00 into main Sep 28, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant