fix(bench): keep reports flowing without install check - #1534
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The benchmark was failing after completing measurements because its final
fbuild install --check --jsonmetadata probe is rejected for registry-pinned non-ESP32 platforms. That made a post-measurement metadata step block publication of otherwise valid timing data.This reads package identities from the successful timed build output instead. The report now distinguishes matched, different, and unverified stacks. Missing or inconsistent identities across any cold trial are recorded as unverified and suppress only the comparison ratio; the cold/warm timing bars still publish. ESP32-S3 compares platform, framework, and toolchain; Uno compares framework and toolchain.
Validation
soldr cargo test -p fbuild-bench-fastled-examples --bin bench-build-comparison— 30 passedsoldr cargo clippy -p fbuild-bench-fastled-examples --bin bench-build-comparison -- -D warnings— passedsoldr cargo fmt --all -- --check— passedThe updated benchmark workflow watches this source path, so merging this PR should automatically run and publish a fresh report.