fix(ci): map Dylint UI nightly to verified driver and sysroot - #1519
Merged
Merged
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: FastLED/fbuild/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux Dylint UI step still compiled a driver because
dylint_testingasks for a shortnightly-2026-05-28directory while Soldr stages the verified binary undernightly-2026-05-28-<host>. Point the short directory at the verified one. The prebuilt driver also forms its sysroot path literally fromRUSTUP_HOME/toolchains/$RUSTUP_TOOLCHAIN, so point the short toolchain directory at the installed host-qualified sysroot.The UI test keeps
RUSTUP_TOOLCHAIN=nightly-2026-05-28, matching the lint library artifact tag. Both aliases are Linux-only and apply to the UI fixture step. No driver or tool is compiled from source.RED -> GREEN: the
ban_manual_slash_normalizeUI fixture failed locally with a missing driver, then a missingstdsysroot, and passed after both aliases were in place. All 21 focused workflow/pin/local lint tests andgit diff --checkpass.