Skip to content

fix(ci): map Dylint UI nightly to verified driver and sysroot - #1519

Merged
zackees merged 1 commit into
mainfrom
fix/dylint-driver-alias
Sep 27, 2026
Merged

zackees merged 1 commit into
mainfrom
fix/dylint-driver-alias

Conversation

@zackees

@zackees zackees commented Sep 27, 2026

Copy link
Copy Markdown
Member

The Linux Dylint UI step still compiled a driver because dylint_testing asks for a short nightly-2026-05-28 directory while Soldr stages the verified binary under nightly-2026-05-28-<host>. Point the short directory at the verified one. The prebuilt driver also forms its sysroot path literally from RUSTUP_HOME/toolchains/$RUSTUP_TOOLCHAIN, so point the short toolchain directory at the installed host-qualified sysroot.

The UI test keeps RUSTUP_TOOLCHAIN=nightly-2026-05-28, matching the lint library artifact tag. Both aliases are Linux-only and apply to the UI fixture step. No driver or tool is compiled from source.

RED -> GREEN: the ban_manual_slash_normalize UI fixture failed locally with a missing driver, then a missing std sysroot, and passed after both aliases were in place. All 21 focused workflow/pin/local lint tests and git diff --check pass.

@zackees
zackees merged commit 8d42c38 into main Sep 27, 2026
17 of 20 checks passed
@zackees
zackees deleted the fix/dylint-driver-alias branch September 27, 2026 19:22
@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: FastLED/fbuild/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 9f337b99-0c3f-4845-9391-b49297ae19fb

📥 Commits

Reviewing files that changed from the base of the PR and between 47bcbc0 and 6a1b16a.

📒 Files selected for processing (1)
  • .github/workflows/dylint.yml
 _______________________________________
< For a good time, call 1-800-COD-RABT. >
 ---------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant