Skip to content

fix(ci): reuse prebuilt driver in Dylint UI fixtures - #1518

Merged
zackees merged 1 commit into
mainfrom
fix/dylint-ui-prebuilt-driver
Sep 27, 2026
Merged

zackees merged 1 commit into
mainfrom
fix/dylint-ui-prebuilt-driver

Conversation

@zackees

@zackees zackees commented Sep 27, 2026

Copy link
Copy Markdown
Member

The exact main Dylint run proved the prebuilt tool and driver selection, then Linux UI fixtures failed because dylint_testing launched Cargo outside Soldr's Dylint front door and built a driver from crates.io. That temporary driver build cleared the nightly selector and failed inside libc's build script.

Pass the verified prebuilt driver root from SOLDR_CACHE_DIR to the Linux UI-test step. Keep the existing dylint-link path handoff. The step is Linux-only, so remove its old Windows path explanation.

Validation: 21 focused workflow, pin, and local lint tests pass; YAML parses; git diff --check passes. The failing Linux job is run 36343216620.

@zackees
zackees merged commit 47bcbc0 into main Sep 27, 2026
15 of 19 checks passed
@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: FastLED/fbuild/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 7a327778-a06e-41e8-82a2-c987b1378c0a

📥 Commits

Reviewing files that changed from the base of the PR and between 1663599 and cc46dcf.

📒 Files selected for processing (1)
  • .github/workflows/dylint.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees deleted the fix/dylint-ui-prebuilt-driver branch September 27, 2026 19:12
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant