fix(ci): reuse prebuilt driver in Dylint UI fixtures - #1518
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 2 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: FastLED/fbuild/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exact main Dylint run proved the prebuilt tool and driver selection, then Linux UI fixtures failed because
dylint_testinglaunched Cargo outside Soldr's Dylint front door and built a driver from crates.io. That temporary driver build cleared the nightly selector and failed inside libc's build script.Pass the verified prebuilt driver root from
SOLDR_CACHE_DIRto the Linux UI-test step. Keep the existingdylint-linkpath handoff. The step is Linux-only, so remove its old Windows path explanation.Validation: 21 focused workflow, pin, and local lint tests pass; YAML parses;
git diff --checkpasses. The failing Linux job is run 36343216620.