Skip to content

fix(ci): clear stable toolchain override for Dylint - #1517

Merged
zackees merged 1 commit into
mainfrom
fix/dylint-manifest-channel
Sep 27, 2026
Merged

zackees merged 1 commit into
mainfrom
fix/dylint-manifest-channel

Conversation

@zackees

@zackees zackees commented Sep 27, 2026

Copy link
Copy Markdown
Member

The first merged-commit Dylint run exposed an ambient selector from setup-soldr: it exports RUSTUP_TOOLCHAIN=1.95.0, which takes precedence over the lint libraries' nightly-2026-05-28 manifests inside soldr dylint prepare. Soldr therefore derived unpublished nightly-2026-02-28 and attempted a driver source build.

Clear RUSTUP_TOOLCHAIN only for Dylint preparation and execution. Keep the stable pin for fbuild's normal jobs and explicit nightly pins for lint formatting and UI tests. The local lint entry point applies the same rule.

Validation: added a RED -> GREEN regression test for inherited stable RUSTUP_TOOLCHAIN; 21 workflow/pin/local lint tests pass, Ruff passes, and git diff --check passes.

@zackees
zackees merged commit 1663599 into main Sep 27, 2026
16 of 20 checks passed
@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 7 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: FastLED/fbuild/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 691818f4-91e3-46db-b476-2a6573c84782

📥 Commits

Reviewing files that changed from the base of the PR and between f551aaa and b24f83d.

📒 Files selected for processing (3)
  • .github/workflows/dylint.yml
  • ci/run_dylint.py
  • ci/test_run_dylint.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees deleted the fix/dylint-manifest-channel branch September 27, 2026 19:07
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant