Skip to content

Resolve explicit PlatformIO registry type paths in core - #1513

Merged
zackees merged 2 commits into
mainfrom
fix/core-explicit-path-1491
Sep 27, 2026
Merged

zackees merged 2 commits into
mainfrom
fix/core-explicit-path-1491

Conversation

@zackees

@zackees zackees commented Sep 27, 2026

Copy link
Copy Markdown
Member

Follow-up to #1491. The core resolver now accepts explicit owner/type/name@version and type/owner/name@version registry paths, normalizes PlatformIO package categories, and rejects mismatched requested kinds. This unblocks platform manifest pins such as Apollo3 toolchain-gccarmnoneeabi. Owner-first takes precedence when both tokens look like types, because registry owner names are unrestricted. Offline core tests cover both forms, malformed paths, and the ambiguous owner case.\n\nValidation: soldr cargo test -p fbuild-core --test platformio_package_resolution; soldr cargo clippy --workspace --all-targets -- -D warnings; soldr cargo fmt --all; git diff --check.

@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 53 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: FastLED/fbuild/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 78103850-8058-4306-b972-5800cb8864bb

📥 Commits

Reviewing files that changed from the base of the PR and between c0ae86e and 674359a.

⛔ Files ignored due to path filters (1)
  • ci/platform_boundary_research.tsv is excluded by !**/*.tsv
📒 Files selected for processing (2)
  • crates/fbuild-core/src/platformio_package.rs
  • crates/fbuild-core/tests/platformio_package_resolution.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees force-pushed the fix/core-explicit-path-1491 branch from 8a82f19 to 674359a Compare September 27, 2026 08:05
@zackees
zackees merged commit e1b372b into main Sep 27, 2026
21 checks passed
@zackees
zackees deleted the fix/core-explicit-path-1491 branch September 27, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant