Skip to content

ci: use setup-soldr ci-tests profile - #1406

Merged
zackees merged 1 commit into
mainfrom
feat/ci-tests-profile
Aug 27, 2026
Merged

zackees merged 1 commit into
mainfrom
feat/ci-tests-profile

Conversation

@zackees

@zackees zackees commented Aug 27, 2026 •

Copy link
Copy Markdown
Member

Use the released setup-soldr ci-tests profile for the Dylint job, preserving its explicit nightly and Dylint pins while eliminating duplicate bootstrap work.

Summary by CodeRabbit

  • Chores
    • Updated the Dylint CI setup to use a centralized, pinned toolchain and utility configuration.
    • Simplified the workflow by removing redundant Dylint installation and driver build steps.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 49 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6d310397-e0a3-4639-9176-376bd08e0e6c

📥 Commits

Reviewing files that changed from the base of the PR and between 2b9256d and e34113e.

📒 Files selected for processing (1)
  • .github/workflows/dylint.yml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a92f6557-558d-44f3-bf11-4e4aaa097908

📥 Commits

Reviewing files that changed from the base of the PR and between ee2add9 and 2b9256d.

📒 Files selected for processing (1)
  • .github/workflows/dylint.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Dylint workflow upgrades setup-soldr and delegates nightly, driver, and tool installation to Soldr through pinned inputs. The previous bootstrap steps were removed.

Changes

Dylint CI setup

Layer / File(s) Summary
Configure Soldr Dylint foundation
.github/workflows/dylint.yml
The workflow upgrades setup-soldr to 0.9.10, enables ci-tests, and pins the nightly toolchain, cargo-dylint, and dylint-link versions. It removes the separate Dylint bootstrap steps.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 2b925

The CI workflow now uses the released setup-soldr ci-tests profile while retaining explicit toolchain and Dylint pins. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating CI to use the setup-soldr ci-tests profile.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/ci-tests-profile

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees force-pushed the feat/ci-tests-profile branch from 2b9256d to ce91d77 Compare August 27, 2026 10:39
@zackees
zackees force-pushed the feat/ci-tests-profile branch from ce91d77 to e34113e Compare August 27, 2026 10:48
@zackees
zackees merged commit 6148d44 into main Aug 27, 2026
17 checks passed
@zackees
zackees deleted the feat/ci-tests-profile branch August 27, 2026 11:00
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant