[OoT] Auto detect non-literal actor scale#716
Open
Jameriquiah wants to merge 1 commit into
Open
Conversation
Dragorn421
approved these changes
Jun 27, 2026
Dragorn421
left a comment
Dragorn421
left a comment
Contributor
There was a problem hiding this comment.
Also tested:
object_hata/gFlagpoleSkel, ovl_En_Hata: Actor_SetScale(&this->dyna.actor, 1.0f / 75.0f); ✅
I think this feature (actor scale detection) isn't super useful tbh, but it's nice to have and the code is clean and readable so sure
Dragorn421
added
merge soon
Author
|
thats fair, most skeletons can be imported without an overlay so its not something strictly necessary. but not entirely sure if every skeleton needs an overlay to import 100% properly. that and more convenient for the user if they are using one since they dont have to bother unchecking stuff or assuming hey this thing doesnt work bc error or anything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
auto detect actor scale was failing for skeleton imports that dont hardcode scale. for example
z_En_Hyderives it's scale fromsInit2Inforather than a literal scale (like a0.01ffor example), causing an import failure if imported with an overlay, for testing i usedobject_cne/gHylianYoungWomanSkel.auto detect actor scale will now locate scale expressions and detect the proper scale from there.