Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

Make db integration superseded - #61

Merged
FaserF merged 1 commit into
mainfrom
superseded-information
Jan 21, 2025
Merged

Make db integration superseded#61
FaserF merged 1 commit into
mainfrom
superseded-information

Conversation

@FaserF

@FaserF FaserF commented Jan 20, 2025

Copy link
Copy Markdown
Owner

Proposed Changes

This will make the ha-deutschebahn superseded by https://github.com/FaserF/ha-db_infoscreen

This will be the last change to this integration, everything new will be done at the new and better integration.

Related Issues

#59
#60

Summary by CodeRabbit

  • Documentation

    • Updated README.md to highlight integration obsolescence
    • Added warning about current integration's limitations
  • Configuration

    • Updated version to 3.0.6
    • Modified configuration descriptions in multiple language files
  • Guidance

    • Directed users to switch to alternative integration (ha-db_infoscreen)
    • Removed previous setup instructions for train station details
  • Logging

    • Updated warning messages in sensor update method

@FaserF FaserF self-assigned this Jan 20, 2025
@coderabbitai

coderabbitai Bot commented Jan 20, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request addresses the shutdown of the Deutsche Bahn integration due to issues with the bahn.de websites. The changes across multiple files indicate a transition strategy, guiding users to switch to a new integration called "ha-db_infoscreen". The modifications include updating the README, version number, sensor logging, and translation strings to consistently communicate the integration's obsolescence and recommend an alternative solution.

Changes

File Change Summary
README.md Reformatted warning about integration shutdown and highlighted new recommended integration
custom_components/deutschebahn/manifest.json Version bumped from 3.0.5 to 3.0.6
custom_components/deutschebahn/sensor.py Updated warning message in async_update method to direct users to new integration
custom_components/deutschebahn/strings.json Replaced configuration descriptions with link to new integration
custom_components/deutschebahn/translations/de.json Updated German translation to guide users to new integration
custom_components/deutschebahn/translations/en.json Updated English translation to guide users to new integration

Poem

🚂 Farewell, Deutsche Bahn, your tracks now fade
A new integration comes to our aid
From bits and bytes, a rabbit's tale unfolds
Of connections lost and new paths bold
Switch now, dear user, to brighter rails! 🐰🛤️


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b1e5681 and 5c73f02.

📒 Files selected for processing (6)
  • README.md (1 hunks)
  • custom_components/deutschebahn/manifest.json (1 hunks)
  • custom_components/deutschebahn/sensor.py (1 hunks)
  • custom_components/deutschebahn/strings.json (2 hunks)
  • custom_components/deutschebahn/translations/de.json (2 hunks)
  • custom_components/deutschebahn/translations/en.json (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@FaserF
FaserF marked this pull request as ready for review January 21, 2025 09:17
@FaserF
FaserF merged commit 0c6f22e into main Jan 21, 2025
@FaserF
FaserF deleted the superseded-information branch January 21, 2025 09:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant