PicklistBase issue #317
Open
PicklistBase issue #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to sync the branch to the origin
Oss2 a feat lr
Signed-off-by: robertli149 <robertli@dickinson.edu>
Final changes for the HW12 assignment
Hackathon sol1
Signed-off-by: robertli149 <robertli@dickinson.edu>
Enhanced DateSelector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Replacing the HTML table in the harvest form with PicklistBase component.
Verification steps
Approach
The PicklistBase component will have styling and behavior that is more consistent with the other FarmData2 forms that use tables.
Testing
Adds data-cy tag to work with Cyprus e2e tests in harvest.e2e.cy.js.
Related issues
Closes #278
Additional information
Authors:
Lilly Roberts
Benjamin Dench
Licensing Certification
FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.