Skip to content

[Fix][Codegen][AIE] Revert Problematic Optimization on Stream Operations - #35

Draft
Fangtangtang wants to merge 1 commit into
mainfrom
stream_op_fix
Draft

[Fix][Codegen][AIE] Revert Problematic Optimization on Stream Operations#35
Fangtangtang wants to merge 1 commit into
mainfrom
stream_op_fix

Conversation

@Fangtangtang

Copy link
Copy Markdown
Owner

Description

This PR partially fixes cornell-zhang#601.

TODO:

  • clean up the stream operation lowering logic.
  • fix the optimization

Problems

Previous optimization on stream operation lowering is too aggressive and didn't consider inter-compute-tile fifo reuse. The leads to the bug mentioned in cornell-zhang#601.

Proposed Solutions

The problematic optimization is temporary disabled. (will lead to some performance degradation)

Checklist

Please make sure to review and check all of these items:

  • PR's title starts with a category (e.g. [Bugfix], [IR], [Builder], etc)
  • All changes have test coverage (It would be good to provide ~2 different test cases to test the robustness of your code)
  • Pass the formatting check locally
  • Code is well-documented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][AIE] Dataflow output is wrong for subtiles > 1

1 participant