Merged
Conversation
Jason-Benson
force-pushed
the
depend9
branch
from
46c71f4 to
9f17b97
Compare
demiankatz
requested changes
Mar 2, 2026
Collaborator
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @Jason-Benson, I hope to have time to look at this hands-on either later today or tomorrow. In the meantime, see below for one more theoretical question.
demiankatz
requested changes
Mar 2, 2026
Collaborator
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
This is great, I'm really happy with how it is shaping up. See below for a couple final nitpicks:
demiankatz
approved these changes
Mar 3, 2026
Collaborator
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
All looking good, and working for me. I confirmed that we were already appropriately passing connection options to all BullMQ objects, so that breaking change in v5 does not impact us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More dependency updates