Deprecate existing matchPattern method#1002
Open
beholderface wants to merge 4 commits intoFallingColors:mainfrom
Open
Deprecate existing matchPattern method#1002beholderface wants to merge 4 commits intoFallingColors:mainfrom
beholderface wants to merge 4 commits intoFallingColors:mainfrom
Conversation
object-Object
requested changes
Feb 19, 2026
|
|
||
| protected boolean canOvercast() { | ||
| //bad deployer, no more infinite bloodcasting for you | ||
| if (this.caster.getClass() != ServerPlayer.class){ |
Member
There was a problem hiding this comment.
This change seems unrelated (and the commit is from a year ago), did something weird happen with the commit history?
| * order | ||
| * for a per-world pattern. | ||
| */ | ||
| @Deprecated |
Member
There was a problem hiding this comment.
Can you add a description to the deprecated annotation, and update the javadoc to mention the new overload?
| return new PatternShapeMatch.Nothing(); | ||
| } | ||
|
|
||
| public static PatternShapeMatch matchPattern(HexPattern pattern, CastingEnvironment environment){ |
Member
There was a problem hiding this comment.
Can you add a javadoc comment to this method?
github-project-automation
bot
moved this from 📋 Backlog
to 🏗 In progress
in Hex Casting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.