Draft
Conversation
- Create api/loaders/sqlserver_loader.py following MySQL/Postgres pattern - Add pymssql dependency to pyproject.toml - Register SQL Server loader in schema_loader.py and text2sql.py - Update DatabaseSpecificQuoter for SQL Server bracket quoting - Update SQLIdentifierQuoter to handle bracket-quoted identifiers - Add SQL Server option to frontend DatabaseModal.tsx - Add unit tests in test_sqlserver_loader.py (11 tests) - Update spellcheck wordlist Agent-Logs-Url: https://github.com/FalkorDB/QueryWeaver/sessions/cb38384c-67c5-45c2-a553-8993ac42376b Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
…_schema and deduplicate test assertion Agent-Logs-Url: https://github.com/FalkorDB/QueryWeaver/sessions/cb38384c-67c5-45c2-a553-8993ac42376b Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Dependency ReviewThe following issues were found:
Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. License Issuesuv.lock
OpenSSF Scorecard
Scanned Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds SQL Server as a supported database backend, alongside PostgreSQL, MySQL, and Snowflake.
Backend
api/loaders/sqlserver_loader.py— New loader usingpymssql, extracting schema viasys.*catalog views. Implements fullBaseLoaderinterface:load,extract_tables_info,extract_columns_info,extract_foreign_keys,extract_relationships,execute_sql_query,is_schema_modifying_query,refresh_graph_schema.api/core/schema_loader.py,api/core/text2sql.py— Registersqlserver://URL prefix →SQLServerLoaderapi/sql_utils/sql_sanitizer.py— Handle SQL Server bracket quoting ([identifier]); refactored_is_already_quotedhelper to support all three quote styles cleanlypyproject.toml— Addedpymssql~=2.3.13Frontend
DatabaseModal.tsx— SQL Server option in type selector,sqlserver://URL placeholder, port 1433 default, protocol in manual URL builderConnection URL format
Tests
test_sqlserver_loader.pycovering URL parsing, serialization, schema modification detection, connection error handling, and successful load flowWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
0.0.0.0.in-addr.arpa/usr/local/bin/node node server.js(dns block)If you need me to access, download, or install something from one of these locations, you can either: