Merged
Conversation
Added lock icons to protected endpoints in Swagger UI Simple descriptions for ApiTokenAuth and SessionAuth when users click "Authorize"
Replace view in dynmic-view
Add GENERAL_PREFIX options for demos
Update swagger
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughAdds OpenAPI tags and custom schema with cookie-based security, documents 401 responses across routes, introduces GENERAL_PREFIX demo-graph handling with guards, adds helper utilities in graphs, updates database/tokens/auth routers with tags, and switches CSS viewport units to dynamic dvw/dvh (with two ddvw typos). Updates .env.example comments. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Client
participant FastAPI App
participant OpenAPI Override
participant get_openapi
Client->>FastAPI App: GET /openapi.json
activate FastAPI App
FastAPI App->>OpenAPI Override: app.openapi()
activate OpenAPI Override
OpenAPI Override->>get_openapi: Build base schema
get_openapi-->>OpenAPI Override: Schema
OpenAPI Override->>OpenAPI Override: Inject ApiTokenAuth, SessionAuth (cookie)
OpenAPI Override->>OpenAPI Override: For ops with 401, set security: [ApiTokenAuth] OR [SessionAuth]
OpenAPI Override-->>FastAPI App: Cached schema
deactivate OpenAPI Override
FastAPI App-->>Client: openapi.json
deactivate FastAPI App
sequenceDiagram
autonumber
participant Client
participant Graphs API
participant Loader
participant SchemaRefresher
participant Formatter
Client->>Graphs API: POST /graphs/{graph_id} (SQL)
alt graph_id starts with GENERAL_PREFIX
Graphs API-->>Client: Stream: "Demo graph—destructive ops blocked" (if destructive)
Graphs API-->>Client: Final result or error
else Non-demo graph
Graphs API->>Loader: Execute SQL
Loader-->>Graphs API: Rows/Effect
opt Schema modified
Graphs API->>SchemaRefresher: Refresh graph schema
SchemaRefresher-->>Graphs API: OK/Fail
end
Graphs API->>Formatter: Format user-friendly response
Formatter-->>Graphs API: Message
Graphs API-->>Client: Stream steps + final message
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (11)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit