Skip to content

feat(security): configure CORS allowed origins - #46

Draft
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
sentinel-cors-fix-9989655151707528310
Draft

google-labs-jules[bot] wants to merge 1 commit into
mainfrom
sentinel-cors-fix-9989655151707528310

Conversation

@google-labs-jules

Copy link
Copy Markdown

Implemented configurable CORS allowed origins for the database_handler service to address the overly permissive Access-Control-Allow-Origin: * vulnerability. The allowed origins can now be set via the DH_ALLOWED_ORIGINS environment variable (comma-separated). If the variable is not set, it defaults to * to maintain backward compatibility, but provides a path to lock down the API in production environments. Updated env.example to encourage restricting access to http://localhost:3000.


PR created automatically by Jules for task 9989655151707528310 started by @lertsoft

- Replaced hardcoded wildcard CORS with configuration.
- Added `AllowedOrigins` to `Config` struct in `database_handler`.
- Defaults to `*` for backward compatibility but allows restriction via `DH_ALLOWED_ORIGINS`.
- Updated `env.example` with a secure default.
- Documented security learning in `.jules/sentinel.md`.
@google-labs-jules

Copy link
Copy Markdown
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants