Skip to content

🎨 Palette: Improve AlertDialog accessibility - #44

Draft
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
palette-accessible-alert-dialog-9409657969667393940
Draft

google-labs-jules[bot] wants to merge 1 commit into
mainfrom
palette-accessible-alert-dialog-9409657969667393940

Conversation

@google-labs-jules

Copy link
Copy Markdown

💡 What: Added standard ARIA attributes (role="alertdialog", aria-modal, aria-labelledby, aria-describedby) to the AlertDialog component and hid decorative icons from screen readers.
🎯 Why: The previous implementation was a generic div overlay, making it difficult for screen reader users to understand they were in a modal or what its content was.
📸 Before/After: Visuals are identical; changes are purely semantic and invisible to sighted users.
♿ Accessibility:

  • Screen readers now announce the component as an alert dialog.
  • The title and description are automatically associated with the dialog.
  • Decorative icons are skipped, reducing noise.

PR created automatically by Jules for task 9409657969667393940 started by @lertsoft

- Add `role="alertdialog"` and `aria-modal="true"` to the modal container.
- Add `aria-labelledby` and `aria-describedby` to link the title and description to the dialog.
- Add `aria-hidden="true"` to decorative icons.
- Ensure proper semantic HTML structure for screen readers.
@google-labs-jules

Copy link
Copy Markdown
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants