fix: patrones glob de .zipignore rotos por delimitador de regex#98
Merged
NeoRazorX merged 2 commits intoJul 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Los patrones con comodines (
*,?) del.zipignoreno excluían nada al generar el zip confsmaker zip, y cada fichero evaluado emitía un warningpreg_match(): Unknown modifier ']'.Por qué sucede
ZipGenerator::globToRegex()convierte*en[^/]*, pero construía la expresión regular con/como delimitador. La barra sin escapar dentro de la clase de caracteres cerraba la regex antes de tiempo, invalidándola.Solución
Usar
~como delimitador de la regex (y en elpreg_quotecorrespondiente). Se añade ademástests/ZipGeneratorTest.phpcubriendo la generación del zip y el filtro de.zipignore(literales, globs, directorios, negaciones, caracteres especiales y casos degenerados); el test convierte cualquier warning depreg_matchen fallo para que esta regresión no vuelva a pasar desapercibida.