Open
Conversation
Collaborator
Author
There was a problem hiding this comment.
With clean up are you referring to line 8?
Member
There was a problem hiding this comment.
Can you provide more details on the BlurDataUrl?
Collaborator
Author
There was a problem hiding this comment.
I generated a base64 version of the Placeholder image, so when loading it displays it. If there is a way to make it shorter, or want to remove it -- let me know.
RichardKruemmel
requested changes
Mar 30, 2023
Member
RichardKruemmel
left a comment
There was a problem hiding this comment.
Please see the comments below the files.
As this is your first PR it is normal that there are more comments and requests from my side. Please don't feel discouraged from it and continue the great work!
…and input validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FAIL test/app/components/Search.test.tsx (8.28 s)
Search
✓ should render the search input (38 ms)
✕ submits the search form with the search value entered by the user (188 ms)
● Search › submits the search form with the search value entered by the user