security: harden CSPRNG, SQL injection guard, error handling, and info disclosure#58
Merged
Merged
Conversation
Copilot created this pull request from a session on behalf of
ernysans
June 17, 2026 12:48
View session
ernysans
marked this pull request as ready for review
June 17, 2026 12:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defensive security pass across
src/addressing six distinct vulnerability classes without altering public API behavior.Changes
Insecure Randomness (
hash-id.ts)Replaced
Math.random()withcrypto.randomInt(). The module is documented as suitable for one-time codes — it must use a CSPRNG.SQL Injection via Identifier Interpolation (
cleaner.ts)dataset,table,timestamp, andcolumnwere interpolated directly into a BigQuery DML template literal. AddedvalidateIdentifier()enforcing^[a-zA-Z_][a-zA-Z0-9_]*$on all four before SQL is built.Unguarded
JSON.parse(global.ts)getPublicUrlandgetUrlAndGscalledJSON.parse(process.env.FIREBASE_CONFIG)with no error handling — a missing or malformed env var produced crypticSyntaxErrorcrashes. Extracted aparseFirebaseConfig()helper that validates presence and catches parse errors with descriptive messages.Non-JSON Error Body (
api-request.ts)response.json()in the non-okpath had no fallback; a non-JSON error body would surface an unhandledSyntaxError. Wrapped intry/catchwith'unknown error'fallback. Also removed aconsole.logthat leakedcontent-typeheaders on every request.User Input in Error Messages (
validate-url.ts)throw new Error(\Invalid URL: ${url}`)reflected raw user input into error messages, enabling log injection. Simplified tothrow new Error('Invalid URL')`.Primitive String Throws (
user.ts)Two
catchblocks usedthrow \template literal`— losing stack traces and breakinginstanceof Errorchecks. Both now usethrow new Error(message, { cause: error })`.